Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate container cluster fields #5261

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Sep 30, 2021

Part of hashicorp/terraform-provider-google#7185, hashicorp/terraform-provider-google#8032

Release Note Template for Downstream PRs (will be copied)

container: deprecated the following `google_container_cluster` fields: `instance_group_urls` and `master_auth` 

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 173 insertions(+), 136 deletions(-))
Terraform Beta: Diff ( 3 files changed, 206 insertions(+), 178 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 35 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 35 insertions(+), 6 deletions(-))

@@ -547,6 +548,7 @@ func resourceContainerCluster() *schema.Resource {
Type: schema.TypeInt,
Optional: true,
ForceNew: true,
Deprecated: `Please use node_pool.initial_node_count instead.`,
Copy link
Member

@rileykarson rileykarson Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should move forward with this deprecation. I know it's deprecated in the API, but the impact is going to be extremely large as many (probably most) users use this to set a node count on their default node pool prior to removal. For a change of this scope we would need a much more in-depth upgrade guide, and a better understanding of the impact.

Particularly, this field is ForceNew and the risk of users accidentally deleting their clusters is fairly high.

@@ -463,6 +463,7 @@ func resourceContainerCluster() *schema.Resource {
Computed: true,
ForceNew: true,
ValidateFunc: orEmpty(validateRFC1918Network(8, 32)),
Deprecated: `Please use ip_allocation_policy.cluster_ipv4_cidr_block instead.`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same w/ initial_node_count (although less extreme), I don't feel great about moving old GKE fields without much more detailed guidance on how to move and understanding of user impact.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeForwardingRule_update|TestAccContainerNodePool_withGPU|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211448

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 23 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 23 insertions(+), 6 deletions(-))

@rileykarson
Copy link
Member

Make sure to update the release note!

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211618

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccSqlUser_postgresIAM Please fix these to complete your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants