Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress diff for COS images #4562

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

melinath
Copy link
Member

@melinath melinath commented Mar 3, 2021

Resolves hashicorp/terraform-provider-google#8601. Upstreams hashicorp/terraform-provider-google#8602.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added suppress diff func for cos-family disk images

@melinath melinath requested review from a team and rileykarson and removed request for a team March 3, 2021 22:44
@google-cla google-cla bot added the cla: yes label Mar 3, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 23 insertions(+))
Terraform Beta: Diff ( 3 files changed, 23 insertions(+))
TF Conversion: Diff ( 2 files changed, 18 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=175379"

@melinath melinath merged commit 74aed18 into GoogleCloudPlatform:master Mar 4, 2021
@melinath melinath deleted the upstream-tpg-8602 branch March 4, 2021 00:07
@melinath
Copy link
Member Author

melinath commented Mar 4, 2021

Test failures look unrelated.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccServiceUsageConsumerQuotaOverride_regionConsumerQuotaOverrideExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=175467"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instances with image = "cos*-lts" are planned to be recreated
4 participants