Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code for Apigee Environments #4553

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

priya-saxena21
Copy link
Contributor

@priya-saxena21 priya-saxena21 commented Mar 2, 2021

Added code for Apigee Environments

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_apigee_environment

@google-cla google-cla bot added the cla: yes label Mar 2, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

@melinath melinath mentioned this pull request Mar 2, 2021
5 tasks
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 769 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 769 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 74 insertions(+))

@modular-magician
Copy link
Collaborator

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 769 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 769 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 74 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 769 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 770 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 74 insertions(+))

@melinath
Copy link
Member

melinath commented Mar 2, 2021

/gcbrun just in case it's needed

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=175175"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 769 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 769 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 74 insertions(+))

@melinath
Copy link
Member

melinath commented Mar 2, 2021

I forgot that the tests for this need to be run manually because VCR tests don't run on PRs. First build failed: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/175182

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM from a code perspective, assuming the tests pass; it looks like there are some other fields that won't be supported yet, but they can always be added in separate PRs later.

parameters:
- !ruby/object:Api::Type::String
name: 'orgId'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the API docs specify this as parent - why does orgId work? https://cloud.google.com/apigee/docs/reference/apis/apigee/rest/v1/organizations.environments/create

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parent is just a URL parameter, so we can call it however we want. We actually have the two models in other resources. For example, the older google_access_context_manager_access_level used parent as is, while the newer google_kms_crypto_key uses the parent as key_ring. The second (with an explicit field name that matches what is expected) seems more readable.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccServiceUsageConsumerQuotaOverride_regionConsumerQuotaOverrideExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=175279"

@melinath
Copy link
Member

melinath commented Mar 3, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants