-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promoted (most of) the supported cloud identity resources to GA #4211
Changes from all commits
497f4bd
9e6ec8c
b404052
fc5d401
09cc045
519a5e7
cf769cd
1d9a9cc
f0a2e81
486deb8
5bd3096
ec15422
31579d1
69e3111
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
resource "google_cloud_identity_group" "group" { | ||
provider = google-beta | ||
display_name = "<%= ctx[:vars]['id_group'] %>" | ||
|
||
parent = "customers/<%= ctx[:test_env_vars]['cust_id'] %>" | ||
|
@@ -14,10 +13,9 @@ resource "google_cloud_identity_group" "group" { | |
} | ||
|
||
resource "google_cloud_identity_group_membership" "cloud_identity_group_membership_basic" { | ||
provider = google-beta | ||
group = google_cloud_identity_group.group.id | ||
|
||
member_key { | ||
preferred_member_key { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is the name changing here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. member_key is only supported in the beta API. This test is being run against the GA API; member_key usage is instead handled by handwritten tests in third_party/terraform/tests/resource_cloud_identity_group_membership_test.go.erb |
||
id = "<%= ctx[:test_env_vars]['identity_user'] %>@<%= ctx[:test_env_vars]['org_domain'] %>" | ||
} | ||
|
||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does
exactly_one_of
work when one field is beta and one isn't?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like exactly_one_of is converted directly into terraform, but using get_property_schema_path and
array.compact
, which seems to be eliminating the beta field from the resulting golang code.In other words, in GA, the go code ends up with a "exactly one of" constraint that doesn't include beta fields - in this case meaning it only contains one property, at least one of which much be specified, which I believe is the correct behavior.