Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_bigquery_job - suppress diffs between fully qualified URLs and relative paths that reference the same table or dataset #3553

Merged

Conversation

jcanseco
Copy link
Member

Release Note Template for Downstream PRs (will be copied)

bigquery: suppressed diffs between fully qualified URLs and relative paths that reference the same table or dataset in `google_bigquery_job`

relative paths that reference the same table or dataset
@jcanseco
Copy link
Member Author

jcanseco commented May 21, 2020

Context: larger discussion with @danawillow in: #3519

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 24 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 1 file changed, 24 insertions(+), 18 deletions(-))

@c2thorn
Copy link
Member

c2thorn commented May 21, 2020

Makes sense, and LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants