Add support for new beta non-rfc fields in dns managed zone #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danawillow
approved these changes
Jan 24, 2020
| Forwarding path for this TargetNameServer. If unset or `default` Cloud DNS will make forwarding | ||
| decision based on address ranges, i.e. RFC1918 addresses go to the VPC, Non-RFC1918 addresses go | ||
| to the Internet. When set to `private`, Cloud DNS will always send queries through VPC for this target | ||
| values: |
There was a problem hiding this comment.
Just want to confirm that the API returns what we send it here- so if we send it "" it returns "" and if we send it "default" it returns "default"?
There was a problem hiding this comment.
Yep, it also unsets based on what we send in the PATCH request, so going from forwarding_path = 'private' to not setting forwarding_path in the config causes it to be removed on the API side as well
slevenick
force-pushed
the
dns-non-rfc
branch
from
4ca6b59
to
3d08eab
Compare
slevenick
force-pushed
the
dns-non-rfc
branch
from
3d08eab
to
adc2364
Compare
This was referenced Jan 25, 2020
Add support for new beta non-rfc fields in dns managed zone
hashicorp/terraform-provider-google#5493
Merged
nathkn
pushed a commit
to nathkn/magic-modules
that referenced
this pull request
May 18, 2020
…oudPlatform#3026) * Add support for new beta non-rfc fields in dns managed zone * Test updating forwarding path * Forgot to remove a param * Typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: hashicorp/terraform-provider-google#5062
I cribbed the object_to_bool and bool_to_object code from: #3007 as this will likely make it in before that.
Release Note Template for Downstream PRs (will be copied)