Inspec storage #2932

slevenick · 2020-01-07T20:22:30Z

Generate InSpec resources for storage buckets, objects, ACLs and IAM

This migrates existing resources that are handwritten

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2020-01-07T20:33:38Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 355a583.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: ansible-collections/google.cloud#125
depends: modular-magician/inspec-gcp#295

modular-magician · 2020-01-07T20:38:53Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b6b6ae7.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#5330

modular-magician · 2020-01-07T21:59:59Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, e547ab7.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2020-01-07T22:20:11Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4b86783.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2020-01-07T22:52:58Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c8a7c6c.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2020-01-07T23:59:41Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5eaa14a.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2020-01-08T00:15:19Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 8ecda42.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#5333

rambleraptor

Looks good on Ansible + MM

rambleraptor · 2020-01-08T00:49:23Z

templates/inspec/integration_test_template.erb

@@ -15,7 +15,7 @@ control '<%= name -%>-1.0' do
  title '<%= name -%> resource test'

 <% if privileged -%>
-  only_if { gcp_enable_privileged_resources.to_i == 1 && gcp_organization_id != ''}
+  only_if { gcp_enable_privileged_resources.to_i == 1 }


Can you do gcp_enable_pribiledged_resources.any? (I honestly don't know)

Oh wait, that would be >= 1, not == 1.

rambleraptor · 2020-01-08T00:52:01Z

products/storage/api.yaml

+        description: 'The name of the object.'
+        required: true
+      - !ruby/object:Api::Type::String
+        name: 'contentType'


Is there a list of possible content types? It would be really nice for users to know what values are possible to expect.

Doesn't have to be an enum, but a link would be helpful (if it exists)

modular-magician · 2020-01-08T20:55:35Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 319efc0.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1606

…m handwritten

… from storage resources, it is not included in response

googlebot added the cla: yes label Jan 7, 2020

modular-magician added downstream-generated ansible inspec labels Jan 7, 2020

modular-magician added the terraform-provider-google label Jan 7, 2020

slevenick requested a review from rambleraptor January 8, 2020 00:41

rambleraptor approved these changes Jan 8, 2020

View reviewed changes

modular-magician added terraform-provider-google-beta automerged labels Jan 8, 2020

slevenick added 9 commits January 8, 2020 21:59

Adding storage bucket, acl, iam binding resource to inspec generation

2000735

Add support for generating inspec storage_* resources, converting fro…

105721e

…m handwritten

Remove project from google_storage_bucket tests, exclude bucket field…

e9d3ef3

… from storage resources, it is not included in response

VCR-ize bucket test

7965bd4

Bucket name fixes, add parse_time method if needed to nested objects

6c5b0ea

Add location to mm bucket

171f84a

Rename to satisfy rubocop

be8e910

Add link to description of content types

e2d078d

modular-magician force-pushed the inspec-storage branch from 319efc0 to e2d078d Compare January 8, 2020 22:00

modular-magician merged commit 60307d0 into GoogleCloudPlatform:master Jan 8, 2020

This was referenced Jan 8, 2020

Inspec storage hashicorp/terraform-provider-google#5347

Merged

Inspec storage hashicorp/terraform-provider-google-beta#1609

Merged

This was referenced Feb 12, 2020

New GCP module: gcp_bigtable_instance ansible/ansible#67332

Closed

New GCP module: gcp_bigtable_instance_info ansible/ansible#67333

Closed

Bug fixes for GCP (as of 2019-11-14T07:04:56Z) ansible/ansible#67562

Closed

modular-magician mentioned this pull request Mar 4, 2020

New GCP module: gcp_storage_default_object_acl ansible/ansible#67988

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inspec storage #2932

Inspec storage #2932

slevenick commented Jan 7, 2020

modular-magician commented Jan 7, 2020

modular-magician commented Jan 7, 2020

modular-magician commented Jan 7, 2020

modular-magician commented Jan 7, 2020

modular-magician commented Jan 7, 2020

modular-magician commented Jan 7, 2020

modular-magician commented Jan 8, 2020

rambleraptor left a comment

rambleraptor Jan 8, 2020

rambleraptor Jan 8, 2020

rambleraptor Jan 8, 2020

slevenick Jan 8, 2020

modular-magician commented Jan 8, 2020

Inspec storage #2932

Inspec storage #2932

Conversation

slevenick commented Jan 7, 2020

modular-magician commented Jan 7, 2020

Pull request statuses

New Pull Requests

modular-magician commented Jan 7, 2020

Pull request statuses

New Pull Requests

modular-magician commented Jan 7, 2020

Pull request statuses

New Pull Requests

modular-magician commented Jan 7, 2020

Pull request statuses

New Pull Requests

modular-magician commented Jan 7, 2020

Pull request statuses

New Pull Requests

modular-magician commented Jan 7, 2020

Pull request statuses

New Pull Requests

modular-magician commented Jan 8, 2020

Pull request statuses

New Pull Requests

rambleraptor left a comment

Choose a reason for hiding this comment

rambleraptor Jan 8, 2020

Choose a reason for hiding this comment

rambleraptor Jan 8, 2020

Choose a reason for hiding this comment

rambleraptor Jan 8, 2020

Choose a reason for hiding this comment

slevenick Jan 8, 2020

Choose a reason for hiding this comment

modular-magician commented Jan 8, 2020

Pull request statuses

New Pull Requests