Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil return for absent Bigtable resources #2927

Closed
wants to merge 1 commit into from
Closed

Nil return for absent Bigtable resources #2927

wants to merge 1 commit into from

Conversation

BrianPi
Copy link
Contributor

@BrianPi BrianPi commented Jan 6, 2020

Return nil after printing "[WARN] Removing %s because it's gone" instead
of an error for Bigtable resources, bringing behaviour in line with other
resource types.

Release Note Template for Downstream PRs (will be copied)


@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@emilymye, please review this PR or find an appropriate assignee.

@BrianPi
Copy link
Contributor Author

BrianPi commented Jan 6, 2020

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Return nil after printing "[WARN] Removing %s because it's gone" instead
of an error for Bigtable resources, bringing behaviour in line with that
of other resource types.
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jan 6, 2020
@emilymye emilymye self-requested a review January 7, 2020 21:34
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 8b593c3.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1597
depends: hashicorp/terraform-provider-google#5331

@emilymye
Copy link
Contributor

emilymye commented Jan 7, 2020

@BrianPi - I'm going to close and recreate this PR (with your same commit) - our autogeneration handles PRs from a master branch poorly

@emilymye
Copy link
Contributor

emilymye commented Jan 7, 2020

Recreated in #2935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants