Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for oauth and oidc tokens to cloud_scheduler_job #2161

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Aug 12, 2019

As referenced in hashicorp/terraform-provider-google#4089 adding support for oauth_token and also oidc_token on the cloud_scheduler job

Release Note for Downstream PRs (will be copied)

Add support for `oauth_token` and `oidc_token` on resource `google_cloud_scheduler_job`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 6084e07.

Pull request statuses

No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1024
depends: GoogleCloudPlatform/terraform-google-conversion#156
depends: hashicorp/terraform-provider-google#4222
depends: modular-magician/ansible#346




func authHeaderDiffSuppress(k, old, new string, d *schema.ResourceData) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mine leaving a comment explaining the expected formats and why we are doing this parsing?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, cf5cc8a.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@megan07 megan07 force-pushed the megan_cloudscheduler_job_auth3 branch 3 times, most recently from 201dde7 to 1ab0382 Compare August 16, 2019 19:08
@megan07 megan07 force-pushed the megan_cloudscheduler_job_auth3 branch from 1ab0382 to 6eec0d8 Compare August 16, 2019 20:19
@megan07 megan07 force-pushed the megan_cloudscheduler_job_auth3 branch from 6eec0d8 to 88a46b7 Compare August 16, 2019 21:09
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 88a46b7.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician modular-magician merged commit e53bda1 into GoogleCloudPlatform:master Aug 16, 2019
@SarahFrench SarahFrench deleted the megan_cloudscheduler_job_auth3 branch March 26, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants