AppEngine Standard Application Version resource. #1884

khanali21 · 2019-06-05T10:40:26Z

This commit adds the AppEngine standard application version resource.
This is work in progress, however I would like to seek initial review from the contributors.

Release Note for Downstream PRs (will be copied)

New output-only fields have been added to google_cloud_run_service' status.

modular-magician · 2019-06-05T10:45:15Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

modular-magician · 2019-06-05T18:08:27Z

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of fae29170cb50ebdc56dd238d8b34578f7bd1f295.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#817
depends: GoogleCloudPlatform/terraform-google-conversion#98
depends: hashicorp/terraform-provider-google#3799

khanali21 · 2019-06-06T15:49:42Z

Is this conflict build/terraform-beta expected?

rileykarson

Good job! Looks like you're on the right track. I have a handful of comments, primarily about convention. They should help resolve some issues as you get to integration testing, particularly the import stage during tests which is a bit fiddly about resource id's.

Also, make sure to add descriptions to all the properties (this is just copied from the GCP rest reference most of the time). As you can see in the current downstreams generated by the Magician, those make up the user-facing documentation for the fields.

The build/ conflict is expected, generally we don't commit changes to the build/ dir. Personally, I keep mine disable with git submodule deinit. I think you can use some combination of git reset and git checkout to revert them to their state at master.

products/appengine/api.yaml

products/appengine/terraform.yaml

templates/terraform/examples/app_engine_standard_app_version.tf.erb

products/appengine/api.yaml

khanali21 · 2019-07-01T13:18:34Z

Hi,
Why the concourse-ci/status is not getting reported? Is there anything I need to do? Please advise.
Thanks in advance.

rileykarson · 2019-07-01T17:10:39Z

Ah, triggering Concourse builds is a manual process for external contributions, once a member of the team has looked over the code briefly. I didn't notice this getting pushed, it didn't trigger a notification for some reason. If you push and want me to take a look, include a comment as well! Those should always result in a notication.

It looks like there's merge conflicts in the build/ folders. I started a build, but I expect they'll cause it to fail. Can you rebase on top of master and update those folders so there's no conflict?

rileykarson · 2019-07-03T20:23:38Z

Looks like the build failed because of Ansible, which has a required field for supported resources. Can you add an exclusion for this resource in appengine/ansible.yaml? Similar to https://github.com/GoogleCloudPlatform/magic-modules/blob/master/products/compute/ansible.yaml#L62-L63

rileykarson · 2019-07-08T16:02:49Z

Oops, sorry for the extra round trip- can you do the same for Service as well?

khanali21 · 2019-07-09T07:14:07Z

No my fault should have checked the api.yml for any other resource. Many thanks for your support @rileykarson

modular-magician · 2019-07-09T16:58:22Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3565fbb.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson

This is a massive resource (the generated downstream is >4000 lines), and ensuring that we've codified the fields correctly will be extremely difficult. What do you think of breaking this into a few phases, adding more configurable fields progressively? That will help keep the size of your changeset down, and help me provide a meaningful review of the resource.

We could potentially release a partially-featured version of the resource sooner as well given that approach.

https://cloud.google.com/appengine/docs/standard/python/getting-started/python-standard-env seems like a good feature set for a first phase. After creating the files in that tutorial and running gcloud app deploy --log-http, gcloud sent this request and got this response back: https://gist.github.com/rileykarson/0fd78db9dd7c6811a4f59d12924cf807

I bet we can make a first pass of this resource supporting only:

deployment
- files
entrypoint
handlers
- script
  - scriptPath
- securityLevel
- urlRegex
id
libraries
- name
- version
runtime
runtimeApiVersion
threadsafe

While there are additional fields in the response, we don't necessarily need them initially, so we can omit them. Once we've merged a PR containing that subset of fields, adding more fields can be done in small sets that are much more manageable and we can iterate on more quickly.

rileykarson · 2019-07-10T19:36:59Z

templates/terraform/examples/app_engine_standard_app_version.tf.erb

+
+resource "google_app_engine_app_version" "<%= ctx[:primary_resource_id] %>" {
+  version_id = "v31"
+  project = "${google_app_engine_application.app.project}/services/default"


Suggested change

project = "${google_app_engine_application.app.project}/services/default"

project = "${google_app_engine_application.app.project}"

service = "default"

I think this is what you want? https://github.com/terraform-providers/terraform-provider-google-beta/pull/817/files#diff-be7a1b17548460da485ebadb23552368R846 will form the request URL.

I agree with you, in fact I had started only with files initially and then added Zip and other fields. I would push the changes as suggested..

modular-magician · 2019-07-12T16:17:06Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c8f2877.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson

Generated downstreams and attempted to run the generated test, I noticed a syntax error in it.

products/appengine/api.yaml

templates/terraform/examples/app_engine_standard_app_version.tf.erb

modular-magician · 2019-07-16T16:20:13Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a003183.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

khanali21 · 2019-07-22T11:09:42Z

@rileykarson Hi Riley, Is there anything I need to do? Please let me know.

googlebot · 2019-07-22T11:09:49Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-07-23T07:40:28Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

modular-magician · 2019-08-22T16:56:10Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 20ca8b5.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson

LGTM!

There's a bug in our generation process that assigns commits in downstream PRs to the user's primary email address and not their original commit email. The commit in GoogleCloudPlatform/terraform-google-conversion#98 is assigned a different email than the one used in this repo.

Do you mind adding that email to your CLA or temporarily changing your primary email setting?

The GitHub setting can be modified at https://github.com/settings/emails. If you choose to change it temporarily, I'll regenerate the downstream so that it's attributed to the appropriate author and then merge this PR. After that, you can safely revert it to your original setting.

If you're uncomfortable with either option, please let me know.

khanali21 · 2019-08-22T23:28:07Z

@rileykarson Done.

modular-magician · 2019-08-23T16:40:50Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 71c3e7d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/terraform-google-conversion#177
depends: modular-magician/inspec-gcp#189

rileykarson · 2019-08-23T17:22:37Z

Hmm, that didn't seem to take. Can you confirm whether you added your email to your corp CLA or changed your GH settings? And if you changed your GH settings, can you confirm that your corporate email has the primary tag on https://github.com/settings/emails?

(the inspec PR generated is ephemeral, the Magician CI has a couple race conditions and we hit one of them.)

khanali21 · 2019-08-24T10:03:12Z

I set the primary address in github to be my corporate address.

khanali21 · 2019-08-25T08:27:10Z

@rileykarson I have squashed and merged in one commit, hopefully this will work.

modular-magician · 2019-08-26T15:36:21Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 97479d3.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/terraform-google-conversion#179
depends: modular-magician/ansible#371

rileykarson

Ah, looks like it's not changing the commit downstream because the contents are the same. I'm applying a change here and then regenerating, this may resolve the issue.

products/appengine/api.yaml

modular-magician · 2019-08-26T16:04:22Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f6a1698.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-26T17:08:25Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 6049abb.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/terraform-google-conversion#180
depends: hashicorp/terraform-provider-google#4336
depends: modular-magician/ansible#372

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician · 2019-08-26T17:43:24Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, eea7d2f.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/terraform-google-conversion#181
depends: hashicorp/terraform-provider-google#4337
depends: modular-magician/ansible#373

rileykarson · 2019-08-26T17:45:48Z

After encountering #2244, merged manually using the Magician user.

googlebot added the cla: yes label Jun 5, 2019

modular-magician added the community label Jun 5, 2019

rileykarson self-requested a review June 5, 2019 14:07

modular-magician added downstream-generated terraform-google-conversion terraform-provider-google-beta terraform-provider-google labels Jun 5, 2019

rileykarson reviewed Jun 6, 2019

View reviewed changes

khanali21 force-pushed the master branch from d4832ff to 6cdc69d Compare July 3, 2019 11:09

khanali21 force-pushed the master branch from ad7daf1 to 3565fbb Compare July 9, 2019 07:13

rileykarson reviewed Jul 10, 2019

View reviewed changes

rileykarson reviewed Jul 12, 2019

View reviewed changes

products/appengine/api.yaml Outdated Show resolved Hide resolved

products/appengine/api.yaml Outdated Show resolved Hide resolved

products/appengine/api.yaml Outdated Show resolved Hide resolved

templates/terraform/examples/app_engine_standard_app_version.tf.erb Show resolved Hide resolved

googlebot added cla: no and removed cla: yes labels Jul 22, 2019

khanali21 force-pushed the master branch from a003183 to 278b48a Compare July 23, 2019 07:40

googlebot removed the cla: no label Jul 23, 2019

rileykarson approved these changes Aug 22, 2019

View reviewed changes

khanali21 force-pushed the master branch from 20ca8b5 to 71c3e7d Compare August 23, 2019 05:32

modular-magician added the inspec label Aug 23, 2019

khanali21 force-pushed the master branch from 71c3e7d to 97479d3 Compare August 25, 2019 08:25

modular-magician added the ansible label Aug 26, 2019

rileykarson reviewed Aug 26, 2019

View reviewed changes

products/appengine/api.yaml Outdated Show resolved Hide resolved

rileykarson mentioned this pull request Aug 26, 2019

AppEngine Standard Application Version resource. GoogleCloudPlatform/terraform-google-conversion#179

Merged

rileykarson added the changelog: enhancement label Aug 26, 2019

modular-magician added the automerged label Aug 26, 2019

khanali21 and others added 2 commits August 26, 2019 16:48

Added appengine standard version resource

57f2c4e

Update products/appengine/api.yaml

6049abb

modular-magician force-pushed the master branch from f6a1698 to 6049abb Compare August 26, 2019 16:48

rileykarson removed the automerged label Aug 26, 2019

modular-magician added the automerged label Aug 26, 2019

Update tracked submodules -> HEAD on Mon Aug 26 17:16:59 UTC 2019

eea7d2f

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician merged commit 32756c9 into GoogleCloudPlatform:master Aug 26, 2019

modular-magician mentioned this pull request Aug 27, 2019

Bug fixes for GCP (as of 2019-08-26T06:05:14+00:00) ansible/ansible#61359

Merged

callppatel mentioned this pull request Aug 27, 2019

GCP Inspec for Standard Application Version #2254

Closed

callppatel mentioned this pull request Sep 9, 2019

GCP Inspec for Standard Application Version #2306

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AppEngine Standard Application Version resource. #1884

AppEngine Standard Application Version resource. #1884

khanali21 commented Jun 5, 2019 •

edited by rileykarson

Loading

modular-magician commented Jun 5, 2019

modular-magician commented Jun 5, 2019

khanali21 commented Jun 6, 2019

rileykarson left a comment

khanali21 commented Jul 1, 2019

rileykarson commented Jul 1, 2019

rileykarson commented Jul 3, 2019

rileykarson commented Jul 8, 2019

khanali21 commented Jul 9, 2019

modular-magician commented Jul 9, 2019

rileykarson left a comment

rileykarson Jul 10, 2019

khanali21 Jul 11, 2019

modular-magician commented Jul 12, 2019

rileykarson left a comment

modular-magician commented Jul 16, 2019

khanali21 commented Jul 22, 2019

googlebot commented Jul 22, 2019

googlebot commented Jul 23, 2019

modular-magician commented Aug 22, 2019

rileykarson left a comment •

edited

Loading

khanali21 commented Aug 22, 2019

modular-magician commented Aug 23, 2019

rileykarson commented Aug 23, 2019 •

edited

Loading

khanali21 commented Aug 24, 2019

khanali21 commented Aug 25, 2019

modular-magician commented Aug 26, 2019

rileykarson left a comment

modular-magician commented Aug 26, 2019

modular-magician commented Aug 26, 2019

modular-magician commented Aug 26, 2019

rileykarson commented Aug 26, 2019

	project = "${google_app_engine_application.app.project}/services/default"
	project = "${google_app_engine_application.app.project}"
	service = "default"

AppEngine Standard Application Version resource. #1884

AppEngine Standard Application Version resource. #1884

Conversation

khanali21 commented Jun 5, 2019 • edited by rileykarson Loading

Release Note for Downstream PRs (will be copied)

modular-magician commented Jun 5, 2019

modular-magician commented Jun 5, 2019

Pull request statuses

New Pull Requests

khanali21 commented Jun 6, 2019

rileykarson left a comment

Choose a reason for hiding this comment

khanali21 commented Jul 1, 2019

rileykarson commented Jul 1, 2019

rileykarson commented Jul 3, 2019

rileykarson commented Jul 8, 2019

khanali21 commented Jul 9, 2019

modular-magician commented Jul 9, 2019

Pull request statuses

New Pull Requests

rileykarson left a comment

Choose a reason for hiding this comment

rileykarson Jul 10, 2019

Choose a reason for hiding this comment

khanali21 Jul 11, 2019

Choose a reason for hiding this comment

modular-magician commented Jul 12, 2019

Pull request statuses

New Pull Requests

rileykarson left a comment

Choose a reason for hiding this comment

modular-magician commented Jul 16, 2019

Pull request statuses

New Pull Requests

khanali21 commented Jul 22, 2019

googlebot commented Jul 22, 2019

googlebot commented Jul 23, 2019

modular-magician commented Aug 22, 2019

Pull request statuses

New Pull Requests

rileykarson left a comment • edited Loading

Choose a reason for hiding this comment

khanali21 commented Aug 22, 2019

modular-magician commented Aug 23, 2019

Pull request statuses

New Pull Requests

rileykarson commented Aug 23, 2019 • edited Loading

khanali21 commented Aug 24, 2019

khanali21 commented Aug 25, 2019

modular-magician commented Aug 26, 2019

Pull request statuses

New Pull Requests

rileykarson left a comment

Choose a reason for hiding this comment

modular-magician commented Aug 26, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 26, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 26, 2019

Pull request statuses

New Pull Requests

rileykarson commented Aug 26, 2019

khanali21 commented Jun 5, 2019 •

edited by rileykarson

Loading

rileykarson left a comment •

edited

Loading

rileykarson commented Aug 23, 2019 •

edited

Loading