Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding deployment_type to GA #12634

Merged
merged 27 commits into from
Dec 26, 2024
Merged

Adding deployment_type to GA #12634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
fa98a0e
adding deployment type to beta provider
unnatinadupalli Nov 19, 2024
3b83e4b
fixing lint
unnatinadupalli Nov 19, 2024
367386c
adding min version beta to example in instance.yaml
unnatinadupalli Nov 19, 2024
e5827d9
Merge branch 'GoogleCloudPlatform:main' into main
unnatinadupalli Dec 12, 2024
924bc1c
adding deployement type to beta provider only and making network a re…
unnatinadupalli Dec 12, 2024
e3e2305
fixing example for ga provider:
unnatinadupalli Dec 12, 2024
f70a2ea
fixing example for ga provider:
unnatinadupalli Dec 12, 2024
589fe73
fixing file name
unnatinadupalli Dec 12, 2024
adefb9d
Merge branch 'GoogleCloudPlatform:main' into main
unnatinadupalli Dec 12, 2024
f057507
minor changes
unnatinadupalli Dec 12, 2024
f6b3a81
rebase
unnatinadupalli Dec 12, 2024
e337fae
minor fixes
unnatinadupalli Dec 12, 2024
1ebb705
fixing example file name
unnatinadupalli Dec 12, 2024
d18dd4d
fixing error with test file
unnatinadupalli Dec 16, 2024
001a111
adding separate tests for ga and beta provider
unnatinadupalli Dec 16, 2024
6242911
test fix
unnatinadupalli Dec 16, 2024
63b71e8
fixing test:
unnatinadupalli Dec 16, 2024
7f72609
fixing test
unnatinadupalli Dec 16, 2024
a1d72e8
fixing test
unnatinadupalli Dec 17, 2024
26fd0c5
fixing test
unnatinadupalli Dec 17, 2024
c2f86d0
fixing test
unnatinadupalli Dec 17, 2024
0c68c85
fixing test
unnatinadupalli Dec 17, 2024
3e23b47
fixing tests
unnatinadupalli Dec 17, 2024
639f6da
Promoting deployment_type field to GA provider
unnatinadupalli Dec 20, 2024
99b3c96
Merge remote-tracking branch 'refs/remotes/origin/main'
unnatinadupalli Dec 20, 2024
7f14979
.
unnatinadupalli Dec 20, 2024
73b1234
adding deployment_type to ga
unnatinadupalli Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mmv1/products/parallelstore/Instance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ properties:
DIRECTORY_STRIPE_LEVEL_MAX
- name: deploymentType
type: String
min_version: 'beta'
description: |
Parallelstore Instance deployment type.
Possible values:
Expand Down
1 change: 1 addition & 0 deletions mmv1/templates/terraform/examples/parallelstore_instance_basic.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ resource "google_parallelstore_instance" "{{$.PrimaryResourceId}}" {
network = google_compute_network.network.name
file_stripe_level = "FILE_STRIPE_LEVEL_MIN"
directory_stripe_level = "DIRECTORY_STRIPE_LEVEL_MIN"
deployment_type = "SCRATCH"
labels = {
test = "value"
}
Expand Down
1 change: 1 addition & 0 deletions ...third_party/terraform/services/parallelstore/resource_parallelstore_instance_test.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ resource "google_parallelstore_instance" "instance" {
capacity_gib = 12000
network = google_compute_network.network.name
reserved_ip_range = google_compute_global_address.private_ip_alloc.name
deployment_type = "SCRATCH"
file_stripe_level = "FILE_STRIPE_LEVEL_MIN"
directory_stripe_level = "DIRECTORY_STRIPE_LEVEL_MIN"
labels = {
Expand Down
Loading