Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AUTH_TYPE_UNSPECIFIED in auth config for connection #12629

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

kanav-google
Copy link
Contributor

@kanav-google kanav-google commented Dec 20, 2024

Some connectors have auth types which are not among standard ones like Private App Token in Hubspot. These are introduced as part of auth type unspecified and the additional variables.

integrationconnectors: allowed `AUTH_TYPE_UNSPECIFIED` option in `google_integration_connectors_connection` resource to support non-standard auth types

@github-actions github-actions bot requested a review from roaks3 December 20, 2024 10:23
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 20, 2024
@modular-magician modular-magician added service/integrationconnectors and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 23, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 3
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • integrationconnectors

🟢 All tests passed!

View the build log

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is intended to fix b/384477234 and b/380393940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants