Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b/383149651 - Make export ranges fields immutable #12592

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

amanMahendroo
Copy link
Contributor

@amanMahendroo amanMahendroo commented Dec 17, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

networkconnectivity: made `includeExportRanges`, `excludeExportRanges` mutable in `google_network_connectivity_spoke` to avoid recreation of resources (b/383149651)

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from BBBmau December 17, 2024 05:55
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/network-connectivity-center and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 17, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 deletions(-))
google-beta provider: Diff ( 1 file changed, 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_spoke (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_spoke" "primary" {
  linked_producer_vpc_network {
    include_export_ranges = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkconnectivity

🟢 All tests passed!

View the build log

@amanMahendroo
Copy link
Contributor Author

Hi @BBBmau , PTAL at this PR, thanks!

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants