Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support IPV6_ONLY configurations for compute API" #12408

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Nov 22, 2024

Reverts #12283
Fixes: hashicorp/terraform-provider-google#17838

Test newly started failing after the introduction. I read the error message and though it was unrelated, paired with the presence of the failing test issue I thought this was already failing for unrelated reasons.

We should lean towards reverting until we can understand what is going on here

compute: `stack_type` can now be set to `IPV6_ONLY` on `google_compute_subnetwork`, `google_compute_instance`, `google_compute_instance_template` and `google_compute_region_instance_template`. REVERTED: PLEASE REMOVE

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 9 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 8 files changed, 9 insertions(+), 12 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field network_interface.ipv6_access_config transitioned from optional+computed to optional google_compute_instance_template - reference
  • Field network_interface.ipv6_access_config transitioned from optional+computed to optional google_compute_instance - reference
  • Field network_interface.ipv6_access_config transitioned from optional+computed to optional google_compute_region_instance_template - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1064
Passed tests: 991
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
3 participants