Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cloud Run v2 Service urls field #12194

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Add Cloud Run v2 Service urls field #12194

merged 1 commit into from
Nov 12, 2024

Conversation

ian-mi
Copy link
Contributor

@ian-mi ian-mi commented Oct 30, 2024 •
edited by NickElliot
Loading

Adds the urls field for v2 Services which contains the recently launched deterministic Service URL in addition to the old style URL set in the singular uri field.

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: added `urls` output field to `google_cloud_run_v2_service` resource

@github-actions github-actions bot requested a review from NickElliot October 30, 2024 18:09
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 25 insertions(+))
google-beta provider: Diff ( 3 files changed, 25 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 43
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleCloudRunV2Service_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleCloudRunV2Service_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

NickElliot
NickElliot reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one question

mmv1/third_party/terraform/services/cloudrunv2/data_source_google_cloud_run_v2_service_test.go
@@ -28,6 +33,8 @@ func TestAccDataSourceGoogleCloudRunV2Service_basic(t *testing.T) {
resource.TestCheckResourceAttr("data.google_cloud_run_v2_service.hello", "id", id),
resource.TestCheckResourceAttr("data.google_cloud_run_v2_service.hello", "name", name),
resource.TestCheckResourceAttr("data.google_cloud_run_v2_service.hello", "location", location),
resource.TestCheckResourceAttr("data.google_cloud_run_v2_service.hello", "urls.#", "2"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given these are output fields, I don't believe they need to be verified in a test like this. is there a reason you added these I'm not realizing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://googlecloudplatform.github.io/magic-modules/contribute/review-pr/: "all fields added/updated in the PR appear in at least one test". If this is not meant to apply to output only fields I wasn't able to find where this is stated.

@ian-mi ian-mi requested a review from NickElliot November 12, 2024 21:25
NickElliot
NickElliot approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the deterministic nature relative to the other verified fields it seems like theres no harm in keeping it alongside the rest, LGTM

@NickElliot NickElliot merged commit 9958bae into GoogleCloudPlatform:main Nov 12, 2024
16 checks passed
This was referenced Nov 12, 2024
Merged
Merged
Gridasov pushed a commit to Gridasov/magic-modules that referenced this pull request Nov 13, 2024
@ian-mi
Add Cloud Run v2 Service urls field (GoogleCloudPlatform#12194)
896ec95
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
@ian-mi @akshat-jindal-nit
Add Cloud Run v2 Service urls field (GoogleCloudPlatform#12194)
6165d69
zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Nov 18, 2024
@ian-mi @zeleena
Add Cloud Run v2 Service urls field (GoogleCloudPlatform#12194)
150b706
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
@ian-mi @amanMahendroo
Add Cloud Run v2 Service urls field (GoogleCloudPlatform#12194)
868a1f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickElliot NickElliot NickElliot approved these changes

@rafaeltello rafaeltello rafaeltello approved these changes

Assignees
No one assigned
Labels
service/run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ian-mi @modular-magician @rafaeltello @NickElliot