Fix bug with updating cloudfunctions vpcConnectorEgressSettings

[nifflets]

Addressed a bug with updating vpc_connector_egress_settings field in Cloud Functions. The Cloud Functions v1 API currently requires the vpc_connector field to be set whenever vpc_connector_egress_settings gets updated, even if there are no changes to vpc_connector. This change modifies the resource update to include vpc_connector when vpc_connector_egress_settings is being updated.

Release Note Template for Downstream PRs (will be copied)

cloudfunctions: Fixed issue when updating `vpc_connector_egress_settings` field for `google_cloudfunctions_function` resource.

b/351195255

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 45 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 45 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 19
Passed tests: 16
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages

• cloudfunctions

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccCloudFunctionsFunction_vpcConnectorEgressSettings

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccCloudFunctionsFunction_vpcConnectorEgressSettings [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 56 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 2 files changed, 58 insertions(+), 19 deletions(-))

[modular-magician]

Tests analytics

Total tests: 19
Passed tests: 6
Skipped tests: 2
Affected tests: 11

Click here to see the affected service packages

• cloudfunctions

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccCloudFunctionsFunction_basic
• TestAccCloudFunctionsFunction_bucket
• TestAccCloudFunctionsFunction_buildServiceAccount
• TestAccCloudFunctionsFunction_buildworkerpool
• TestAccCloudFunctionsFunction_dockerRepository
• TestAccCloudFunctionsFunction_pubsub
• TestAccCloudFunctionsFunction_serviceAccountEmail
• TestAccCloudFunctionsFunction_sourceRepo
• TestAccCloudFunctionsFunction_update
• TestAccCloudFunctionsFunction_vpcConnector
• TestAccCloudFunctionsFunction_vpcConnectorEgressSettings

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccCloudFunctionsFunction_basic [Debug log]
TestAccCloudFunctionsFunction_bucket [Debug log]
TestAccCloudFunctionsFunction_buildServiceAccount [Debug log]
TestAccCloudFunctionsFunction_buildworkerpool [Debug log]
TestAccCloudFunctionsFunction_dockerRepository [Debug log]
TestAccCloudFunctionsFunction_pubsub [Debug log]
TestAccCloudFunctionsFunction_serviceAccountEmail [Debug log]
TestAccCloudFunctionsFunction_sourceRepo [Debug log]
TestAccCloudFunctionsFunction_update [Debug log]
TestAccCloudFunctionsFunction_vpcConnectorEgressSettings [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccCloudFunctionsFunction_vpcConnector [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 114 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 2 files changed, 116 insertions(+), 14 deletions(-))

[modular-magician]

Tests analytics

Total tests: 19
Passed tests: 16
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages

• cloudfunctions

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccCloudFunctionsFunction_vpcConnector

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccCloudFunctionsFunction_vpcConnector [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[melinath]

Reassigning this PR review.