Promoting Memorystore to GA

[himanikh]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_memorystore_instance` (ga)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 2457 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 3 files changed, 14 insertions(+), 50 deletions(-))
Open in Cloud Shell: Diff ( 12 files changed, 460 insertions(+))

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• memorystore

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccMemorystoreInstance_memorystoreInstanceBasicExample
• TestAccMemorystoreInstance_memorystoreInstanceFullExample
• TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample
• TestAccMemorystoreInstance_updateDeletionProtection
• TestAccMemorystoreInstance_updatePersistence
• TestAccMemorystoreInstance_updateRedisConfigs
• TestAccMemorystoreInstance_updateReplicaCount
• TestAccMemorystoreInstance_updateShardCount
  🟢 All tests passed!

View the build log

[SirGitsalot]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 2457 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 3 files changed, 14 insertions(+), 50 deletions(-))
Open in Cloud Shell: Diff ( 12 files changed, 460 insertions(+))

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• memorystore

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccMemorystoreInstance_memorystoreInstanceBasicExample
• TestAccMemorystoreInstance_memorystoreInstanceFullExample
• TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample
• TestAccMemorystoreInstance_updateDeletionProtection
• TestAccMemorystoreInstance_updatePersistence
• TestAccMemorystoreInstance_updateRedisConfigs
• TestAccMemorystoreInstance_updateReplicaCount
• TestAccMemorystoreInstance_updateShardCount
  🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 2554 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 3 files changed, 8 insertions(+), 45 deletions(-))
Open in Cloud Shell: Diff ( 12 files changed, 460 insertions(+))

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• memorystore

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccMemorystoreInstance_memorystoreInstanceBasicExample
• TestAccMemorystoreInstance_memorystoreInstanceFullExample
• TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample
• TestAccMemorystoreInstance_updateDeletionProtection
• TestAccMemorystoreInstance_updatePersistence
• TestAccMemorystoreInstance_updateRedisConfigs
• TestAccMemorystoreInstance_updateReplicaCount
• TestAccMemorystoreInstance_updateShardCount
  🟢 All tests passed!

View the build log

[SirGitsalot]

I ran the GA tests manually and they passed with flying colors. LGTM, but with a nit I'd like to resolve first: please revert the single to double quote line changes in Instance.yaml (it's not that we particularly care about quote formatting, but it screws up the change history and makes future bug discovery harder).

[himanikh]

I ran the GA tests manually and they passed with flying colors. LGTM, but with a nit I'd like to resolve first: please revert the single to double quote line changes in Instance.yaml (it's not that we particularly care about quote formatting, but it screws up the change history and makes future bug discovery harder).

Yeah, this was all auto formatter's doing. Reverted the Instance.yaml to single quotes.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 2554 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 3 files changed, 8 insertions(+), 45 deletions(-))
Open in Cloud Shell: Diff ( 12 files changed, 460 insertions(+))

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• memorystore

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccMemorystoreInstance_memorystoreInstanceBasicExample
• TestAccMemorystoreInstance_memorystoreInstanceFullExample
• TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample
• TestAccMemorystoreInstance_updateDeletionProtection
• TestAccMemorystoreInstance_updatePersistence
• TestAccMemorystoreInstance_updateRedisConfigs
• TestAccMemorystoreInstance_updateReplicaCount
• TestAccMemorystoreInstance_updateShardCount
  🟢 All tests passed!

View the build log

[github-actions]

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[SirGitsalot]

Re-ran the tests manually, they again passed. LGTM!