Filestore protocol GA

[KaramanJoe]

Since 30th September Filestore Protocol selection is now in GA. This PR allows deployment of a NFS_v4 Filestore instance without using the google-beta provider.
https://cloud.google.com/filestore/docs/release-notes#September_30_2024

Release Note Template for Downstream PRs (will be copied)

filestore: Migrated `protocol` property for `google_filestore_instance` from Beta to GA

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 80 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 4 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 12
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• filestore

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccFilestoreInstance_filestoreInstanceProtocolExample
  🟢 All tests passed!

View the build log

[roaks3]

Confirmed GA test:

TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/filestore -v -run=TestAccFilestoreInstance_filestoreInstanceProtocolExample -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccFilestoreInstance_filestoreInstanceProtocolExample
=== PAUSE TestAccFilestoreInstance_filestoreInstanceProtocolExample
=== CONT  TestAccFilestoreInstance_filestoreInstanceProtocolExample
--- PASS: TestAccFilestoreInstance_filestoreInstanceProtocolExample (679.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-google/google/services/filestore	681.407s