rewrite - more convert script changes #11799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2thorn
commented
Sep 24, 2024
| @@ -36,12 +36,6 @@ class FileTemplate | |||
| # Once the file's contents are written, set the proper [chmod] mode and | |||
| # format the file with a language-appropriate formatter. | |||
| def generate(pwd, template, path, provider) | |||
| # If we've modified a file since starting an MM run, it's a reasonable | |||
| # assumption that it was this run that modified it. | |||
| if File.exist?(path) && File.mtime(path) > @env[:start_time] | |||
There was a problem hiding this comment.
Gets raised when trying to convert a product.yaml file with product.yaml.temp
I think we are close enough to the migration to turn this off
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
1 similar comment
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
NickElliot
approved these changes
Sep 24, 2024
This was referenced Sep 24, 2024
abd-goog
pushed a commit
to abd-goog/magic-modules
that referenced
this pull request
Sep 26, 2024
niharika-98
pushed a commit
to niharika-98/magic-modules
that referenced
this pull request
Oct 7, 2024
Philip-Jonany
pushed a commit
to Philip-Jonany/magic-modules
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)