Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite - private override changes #11788

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Sep 23, 2024

adds --override flag to the go engine for private overrides

needs to be combined with the changes in the private overrides internal repo to test, but produces only minor diffs.

Release Note Template for Downstream PRs (will be copied)


@c2thorn c2thorn changed the title private override changes rewrite - private override changes Sep 23, 2024
@c2thorn c2thorn mentioned this pull request Sep 23, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@c2thorn c2thorn requested a review from zli82016 September 23, 2024 19:06
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c2thorn c2thorn merged commit 6b7012d into GoogleCloudPlatform:main Sep 23, 2024
10 checks passed
@c2thorn c2thorn deleted the rewrite-private-overrides branch September 23, 2024 20:17
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 26, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants