Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# Add: biglake_configuration to bigquery_table #11724

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

nevzheng
Copy link
Contributor

@nevzheng nevzheng commented Sep 16, 2024

Add support for BigLakeConfiguration in the BigQuery Table Resource to support BigLake Managed Tables

Release Note Template for Downstream PRs (will be copied)

bigquery: added `biglake_configuration` to `google_bigquery_table` to support BigLake Managed Tables

As BigLake Managed Tables are in public preview, we can now support BLMT in the Terraform provider.
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 125 insertions(+))
google-beta provider: Diff ( 3 files changed, 125 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 120
Passed tests: 109
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages
  • bigquery

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigQueryBigLakeManagedTable

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryBigLakeManagedTable[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@trodge trodge merged commit 6555ae7 into GoogleCloudPlatform:main Sep 19, 2024
11 of 12 checks passed
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants