Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go rewrite - 9/16 refresh #11721

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Sep 16, 2024

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 26 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 5 files changed, 26 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 25
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • secretmanagerregional

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@c2thorn
Copy link
Member Author

c2thorn commented Sep 16, 2024

I'll actually wait for #11715 to be merged

@c2thorn c2thorn merged commit 6b9eead into GoogleCloudPlatform:main Sep 16, 2024
14 checks passed
@c2thorn c2thorn deleted the rewrite-refresh branch September 16, 2024 17:56
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants