Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use target org for security postures #11692

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

slevenick
Copy link
Contributor

This constraint causes issues in storage tests if it exists in the org.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3
Passed tests: 0
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • securityposture

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityPosturePostureDeployment_securityposturePostureDeployment_update
  • TestAccSecurityposturePosture_securityposturePostureBasicExample
  • TestAccSecurityposturePosture_securityposturePosture_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityPosturePostureDeployment_securityposturePostureDeployment_update[Error message] [Debug log]
TestAccSecurityposturePosture_securityposturePostureBasicExample[Error message] [Debug log]
TestAccSecurityposturePosture_securityposturePosture_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3
Passed tests: 0
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • securityposture

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityPosturePostureDeployment_securityposturePostureDeployment_update
  • TestAccSecurityposturePosture_securityposturePostureBasicExample
  • TestAccSecurityposturePosture_securityposturePosture_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityPosturePostureDeployment_securityposturePostureDeployment_update[Error message] [Debug log]
TestAccSecurityposturePosture_securityposturePostureBasicExample[Error message] [Debug log]
TestAccSecurityposturePosture_securityposturePosture_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3
Passed tests: 0
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • securityposture

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityPosturePostureDeployment_securityposturePostureDeployment_update
  • TestAccSecurityposturePosture_securityposturePostureBasicExample
  • TestAccSecurityposturePosture_securityposturePosture_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityPosturePostureDeployment_securityposturePostureDeployment_update[Debug log]
TestAccSecurityposturePosture_securityposturePostureBasicExample[Debug log]
TestAccSecurityposturePosture_securityposturePosture_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@slevenick slevenick requested a review from trodge September 12, 2024 19:35
@trodge trodge merged commit 3c92482 into GoogleCloudPlatform:main Sep 12, 2024
12 checks passed
iyabchen pushed a commit to iyabchen/magic-modules that referenced this pull request Sep 14, 2024
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants