Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dnssecConfig filed on google_dns_managed_zone resource #11632

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Samir-Cit
Copy link
Contributor

@Samir-Cit Samir-Cit commented Sep 4, 2024

This PR fixes the issue hashicorp/terraform-provider-google#17682 by adding a default_from_api: true config on dnssecConfig field on the resouce google_dns_managed_zone.
This will prevent the terraform diff when running a second apply which the resource was changed outside terraform.

Release Note Template for Downstream PRs (will be copied)

dns: fixed permadiff on `dnssec_config` field of `google_dns_managed_zone` resource

@github-actions github-actions bot requested a review from roaks3 September 4, 2024 16:12
Copy link

github-actions bot commented Sep 4, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 4, 2024
Copy link

github-actions bot commented Sep 9, 2024

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/cloud-dns and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 12, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 46
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • dns

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants