-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make vcr tester Run and RunParallel use options struct #11628
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - could you push a commit to force test runs just to be extra safe?
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
1 similar comment
Tests analyticsTotal tests: 51 Click here to see the affected service packages
View the build log |
Tests analyticsTotal tests: 51 Click here to see the affected service packages
View the build log |
This reverts commit c080d52.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
…atform#11628) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…atform#11628) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…atform#11628) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Adding an options struct for these methods so that their parameters can be changed without breaking current usage.
Release Note Template for Downstream PRs (will be copied)