Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Composer] Reveal cloud_data_lineage_integration to GA. #11619

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

ahidalgob
Copy link
Member

@ahidalgob ahidalgob commented Sep 3, 2024

Google Cloud Composer has promoted Data Lineage integration to GA.
Fixes hashicorp/terraform-provider-google#19345

Release Note Template for Downstream PRs (will be copied)

composer: promoted `config.0.workloads_config.0.cloud_data_lineage_integration` to GA in resource `google_composer_environment`

@github-actions github-actions bot requested a review from NickElliot September 3, 2024 11:55
Copy link

github-actions bot commented Sep 3, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@ahidalgob
Copy link
Member Author

make testacc TEST=./google/services/composer/ TESTARGS='-run=TestAccComposerEnvironment_ComposerV2'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/composer/ -v -run=TestAccComposerEnvironment_ComposerV2 -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccComposerEnvironment_ComposerV2
=== PAUSE TestAccComposerEnvironment_ComposerV2
=== RUN   TestAccComposerEnvironment_ComposerV2HighResilience
=== PAUSE TestAccComposerEnvironment_ComposerV2HighResilience
=== CONT  TestAccComposerEnvironment_ComposerV2
=== CONT  TestAccComposerEnvironment_ComposerV2HighResilience
--- PASS: TestAccComposerEnvironment_ComposerV2 (1269.27s)
--- PASS: TestAccComposerEnvironment_ComposerV2HighResilience (1289.29s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/composer 1289.711s

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 73 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

Copy link

github-actions bot commented Sep 6, 2024

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor docs edits needed but otherwise seems good

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 73 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 73 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 73 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 1 file changed, 2 insertions(+), 4 deletions(-))

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants