Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding accelerators[] for NodeTemplate #11511

Conversation

matthewhuie
Copy link
Contributor

@matthewhuie matthewhuie commented Aug 21, 2024

Adds accelerators[] field for NodeTemplate to support GPU accelerators in sole tenant node templates

Fixes hashicorp/terraform-provider-google#19201

compute: added `accelerators` field to `google_compute_node_template` resource

@github-actions github-actions bot requested a review from NickElliot August 21, 2024 16:17
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 197 insertions(+))
google-beta provider: Diff ( 3 files changed, 197 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 43 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 115 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 983
Passed tests: 910
Skipped tests: 72
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNodeTemplate_nodeTemplateAcceleratorsExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeNodeTemplate_nodeTemplateAcceleratorsExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 197 insertions(+))
google-beta provider: Diff ( 3 files changed, 197 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 43 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 115 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 984
Passed tests: 910
Skipped tests: 72
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeDisk_storagePoolSpecified
  • TestAccComputeInstance_bootDisk_storagePoolSpecified

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly LGTM, just this small change off my first pass

mmv1/products/compute/NodeTemplate.yaml Outdated Show resolved Hide resolved
Co-authored-by: Nick Elliot <nickelliot@google.com>
@github-actions github-actions bot requested a review from NickElliot August 26, 2024 20:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 197 insertions(+))
google-beta provider: Diff ( 3 files changed, 197 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 43 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 115 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 989
Passed tests: 912
Skipped tests: 77
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add accelerators[] to NodeTemplate
3 participants