Add FIPS enablement option to Looker

[efeelaiho]

Add FIPS enablement option to Looker

Release Note Template for Downstream PRs (will be copied)

looker: added field `fips_enabled` to resource `google_looker_instance`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 36 insertions(+))
google-beta provider: Diff ( 2 files changed, 36 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  fips_enabled = # value needed
}

[modular-magician]

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• looker

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[ScottSuarez]

Is this field GA? I don't see it documented at https://cloud.google.com/looker/docs/reference/rest/v1/projects.locations.instances

[efeelaiho]

@ScottSuarez Hi, no it is not officially GA yet, it is behind a visibility label. However it is planned to be GA at the end of the month, with expectations to use the field immediately in Terraform once it GAs.

[ScottSuarez]

Do you have a specific date? I want to make sure this field doesn't confuse customers as it won't be available at the time the release notes are published. In general I believe it might be okay in this instance as the delta between the next release and your feature release is potentially small.

[efeelaiho]

So I do not have a specific date, but GA is immediately after our rollout which ends Sept 2/3

[ScottSuarez]

From my team lead on merging changes before GA.
''
If they soft launch (i.e. launch API before the blog post / conference announcement) we can add it to the GA provider during the soft launch period

Otherwise we'd recommend EAP or beta depending on the situation, promoting to GA later. Beta if non-allowlisted and EAP otherwise.
''

[github-actions]

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[ScottSuarez]

Waiting for GA

[github-actions]

@efeelaiho, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 100 insertions(+))
google-beta provider: Diff ( 3 files changed, 100 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 113 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  fips_enabled = # value needed
}

[modular-magician]

Tests analytics

Total tests: 6
Passed tests: 5
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• looker

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_lookerInstanceFipsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 98 insertions(+))
google-beta provider: Diff ( 3 files changed, 98 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 112 insertions(+))

[modular-magician]

Tests analytics

Total tests: 6
Passed tests: 5
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• looker

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_lookerInstanceFipsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccLookerInstance_lookerInstanceFipsExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test