Add tags field to Folder resource

[abd-goog]

Add tags field to folder resource to allow setting tags on folder resources at creation time.
Part of b/330143705

Part of hashicorp/terraform-provider-google#18904

Release Note Template for Downstream PRs (will be copied)

resourcemanager: added `tags` field to `google_folder` to allow setting tags for folders at creation time

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 50 insertions(+), 28 deletions(-))
google-beta provider: Diff ( 2 files changed, 50 insertions(+), 28 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 50 insertions(+), 28 deletions(-))
google-beta provider: Diff ( 2 files changed, 50 insertions(+), 28 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccFolder_tags
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccFolder_tags
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 54 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 54 insertions(+), 1 deletion(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccFolder_tags
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 52 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 52 insertions(+), 4 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 52 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 52 insertions(+), 4 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccFolder_tags
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccFolder_tags
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 95 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 95 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_folder (135 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_folder" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 145
Passed tests: 114
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFolder_tags

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccFolder_tags[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[abd-goog]

Hi @slevenick @zli82016 , can we include this change in the major release? Or it needs to go in one of the regular releases later?

[abd-goog]

Tests failed during RECORDING mode: TestAccFolder_tags[Error message] [Debug log]

Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@zli82016 The test passes on local, but would need help from TF team to add the tags resource in the test organization and provide tag admin permission to VCR test user.
Or should I mark this test as skipped?

[zli82016]

Hi @slevenick @zli82016 , can we include this change in the major release? Or it needs to go in one of the regular releases later?

@abd-goog , do you know how many resources tags need to be added?

[abd-goog]

Hi @slevenick @zli82016 , can we include this change in the major release? Or it needs to go in one of the regular releases later?

@abd-goog , do you know how many resources tags need to be added?

@zli82016 right now only CRM projects and folders are eligible and CRM wants to go GA with Tagging at creation as soon as possible.
There will be other resources in the coming weeks but for now we need to prioritize for Projects and Folders only.

[zli82016]

Hi @slevenick @zli82016 , can we include this change in the major release? Or it needs to go in one of the regular releases later?

@abd-goog , do you know how many resources tags need to be added?

@zli82016 right now only CRM projects and folders are eligible and CRM wants to go GA with Tagging at creation as soon as possible. There will be other resources in the coming weeks but for now we need to prioritize for Projects and Folders only.

Either major release or later regular release is fine.

[abd-goog]

Hi @slevenick @zli82016 , can we include this change in the major release? Or it needs to go in one of the regular releases later?

@abd-goog , do you know how many resources tags need to be added?

@zli82016 right now only CRM projects and folders are eligible and CRM wants to go GA with Tagging at creation as soon as possible. There will be other resources in the coming weeks but for now we need to prioritize for Projects and Folders only.

Either major release or later regular release is fine.

Would be great to get it in the major release. FYI the PR for projects resource: #11440

[zli82016]

Tests failed during RECORDING mode: TestAccFolder_tags[Error message] [Debug log]
Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test

@zli82016 The test passes on local, but would need help from TF team to add the tags resource in the test organization and provide tag admin permission to VCR test user. Or should I mark this test as skipped?

What do you mean to add the tags resource in the test organization, @abd-goog ?
This is the post request:

{
 "displayName": "tf-test-k7z9737heo",
 "parent": "organizations/529579013760",
 "tags": {
  "529579013760/env": "test"
 }
}

should the tag "529579013760/env": "test" exist before creating the new folder?

[zli82016]

Tests failed during RECORDING mode: TestAccFolder_tags[Error message] [Debug log]
Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test

@zli82016 The test passes on local, but would need help from TF team to add the tags resource in the test organization and provide tag admin permission to VCR test user. Or should I mark this test as skipped?

Tests failed during RECORDING mode: TestAccFolder_tags[Error message] [Debug log]
Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test

@zli82016 The test passes on local, but would need help from TF team to add the tags resource in the test organization and provide tag admin permission to VCR test user. Or should I mark this test as skipped?

You need to create the tags resource with Terraform configuration in the same test.

[zli82016]

Modify test to include tags creation.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 100 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 100 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_folder (143 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_folder" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccFolder_tags
  $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 100 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 100 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_folder (145 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_folder" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 147
Passed tests: 116
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFolder_tags

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccFolder_tags[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[abd-goog]

@zli82016 PTAL, have updated tests to use bootstrapping logic. Thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 100 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 100 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_folder (145 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_folder" "primary" {
  tags = # value needed
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 100 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 100 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_folder (145 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_folder" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 147
Passed tests: 116
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFolder_tags

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccFolder_tags[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 147
Passed tests: 116
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFolder_tags

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFolder_tags[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[zli82016]

LGTM