feat: support Cloud SQL's new field server_ca_mode.
#11331
Conversation
…ion.server_ca_mode
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@trodge Hi Thomas, do you know why the above |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_sql_database_instance" "primary" {
settings {
ip_configuration {
enable_private_path_for_google_cloud_services = # value needed
}
}
}
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_sql_database_instance" "primary" {
settings {
ip_configuration {
enable_private_path_for_google_cloud_services = # value needed
}
}
}
|
Tests analyticsTotal tests: 3884 Click here to see the affected service packages
Action takenFound 44 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 3885 Click here to see the affected service packages
Action takenFound 44 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
|
…not be enabled now.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_sql_database_instance" "primary" {
settings {
ip_configuration {
enable_private_path_for_google_cloud_services = # value needed
server_ca_mode = # value needed
}
}
}
|
Tests analyticsTotal tests: 3884 Click here to see the affected service packages
Action takenFound 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_sql_database_instance" "primary" {
settings {
ip_configuration {
enable_private_path_for_google_cloud_services = # value needed
server_ca_mode = # value needed
}
}
}
|
Tests analyticsTotal tests: 3884 Click here to see the affected service packages
Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
@trodge Hi Thomas, I believe the above failed ACC tests are not related to this PR. I see some of them failing in other PRs too. Thanks. |
mmv1/third_party/terraform/website/docs/r/sql_database_instance.html.markdown
Outdated
Show resolved
Hide resolved
…e.html.markdown Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
…tform#11331) Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
…tform#11331) Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
This PR supports the new field
settings.ip_configuration.server_ca_modeof Cloud SQL instances.Release Note Template for Downstream PRs (will be copied)