Add deletion_protection field to CloudAD domain resource #11256

abd-goog · 2024-07-25T11:12:49Z

Add deletion_protection field to make deletion actions require an explicit intent
Part of b/337047978

Part of hashicorp/terraform-provider-google#18854

Release Note Template for Downstream PRs (will be copied)

activeDirectory: added `deletion_protection` field to `google_active_directory_domain` to make deleting them require an explicit intent. `google_active_directory_domain` resources now cannot be destroyed unless `deletion_protection = false` is set for the resource.

modular-magician · 2024-07-25T11:24:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 24 files changed, 301 insertions(+), 64 deletions(-))
google-beta provider: Diff ( 25 files changed, 310 insertions(+), 65 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 11 insertions(+), 7 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 4 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field backend.balancing_mode default value changed from CONNECTION to UTILIZATION on google_compute_region_backend_service - reference
Field connection_draining_timeout_sec default value changed from 0 to 300 on google_compute_region_backend_service - reference
Field max_throughput default value changed from 300 to on google_vpc_access_connector - reference
Field min_throughput default value changed from 200 to on google_vpc_access_connector - reference
Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_backend_service - reference
Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_region_backend_service - reference
Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_backend_service - reference
Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_region_backend_service - reference
Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_backend_service - reference
Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_region_backend_service - reference
Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_backend_service - reference
Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_region_backend_service - reference
Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_backend_service - reference
Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_region_backend_service - reference
Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_backend_service - reference
Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_region_backend_service - reference
Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_backend_service - reference
Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_region_backend_service - reference
Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_backend_service - reference
Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_region_backend_service - reference
Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_backend_service - reference
Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_region_backend_service - reference
Field schema_settings transitioned from optional+computed to optional google_pubsub_topic - reference
Field template.containers.liveness_probe transitioned from optional+computed to optional google_cloud_run_v2_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2024-07-25T11:28:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 24 files changed, 301 insertions(+), 64 deletions(-))
google-beta provider: Diff ( 25 files changed, 310 insertions(+), 65 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 11 insertions(+), 7 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 4 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field backend.balancing_mode default value changed from CONNECTION to UTILIZATION on google_compute_region_backend_service - reference
Field connection_draining_timeout_sec default value changed from 0 to 300 on google_compute_region_backend_service - reference
Field max_throughput default value changed from 300 to on google_vpc_access_connector - reference
Field min_throughput default value changed from 200 to on google_vpc_access_connector - reference
Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_backend_service - reference
Field outlier_detection.consecutive_errors default value changed from 5 to on google_compute_region_backend_service - reference
Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_backend_service - reference
Field outlier_detection.consecutive_gateway_failure default value changed from 5 to on google_compute_region_backend_service - reference
Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_backend_service - reference
Field outlier_detection.enforcing_consecutive_errors default value changed from 100 to on google_compute_region_backend_service - reference
Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_backend_service - reference
Field outlier_detection.enforcing_consecutive_gateway_failure default value changed from 0 to on google_compute_region_backend_service - reference
Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_backend_service - reference
Field outlier_detection.enforcing_success_rate default value changed from 100 to on google_compute_region_backend_service - reference
Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_backend_service - reference
Field outlier_detection.max_ejection_percent default value changed from 10 to on google_compute_region_backend_service - reference
Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_backend_service - reference
Field outlier_detection.success_rate_minimum_hosts default value changed from 5 to on google_compute_region_backend_service - reference
Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_backend_service - reference
Field outlier_detection.success_rate_request_volume default value changed from 100 to on google_compute_region_backend_service - reference
Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_backend_service - reference
Field outlier_detection.success_rate_stdev_factor default value changed from 1900 to on google_compute_region_backend_service - reference
Field schema_settings transitioned from optional+computed to optional google_pubsub_topic - reference
Field template.containers.liveness_probe transitioned from optional+computed to optional google_cloud_run_v2_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2024-07-25T11:49:06Z

Tests analytics

Total tests: 1225
Passed tests: 1051
Skipped tests: 91
Affected tests: 83

Click here to see the affected service packages

vpcaccess

activedirectory

appengine

bigquery

cloudfunctions

cloudrunv2

compute

pubsub

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccVPCAccessConnector_vpcAccessConnectorThroughput_combiningThroughputAndInstancesFields_conflict

Action taken

Found 83 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunV2Job_cloudrunv2JobFullUpdate

TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample

TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate

TestAccCloudRunV2Service_cloudrunv2ServiceGRPCProbesUpdate

TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample

TestAccComputeBackendService_trafficDirectorUpdateBasic

TestAccComputeBackendService_trafficDirectorUpdateFull

TestAccComputeBackendService_trafficDirectorUpdateLbPolicies

TestAccComputeForwardingRule_forwardingRuleExternallbExample

TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample

TestAccComputeForwardingRule_forwardingRuleHttpLbExample

TestAccComputeForwardingRule_forwardingRuleInternallbExample

TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example

TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6

TestAccComputeForwardingRule_forwardingRuleL3DefaultExample

TestAccComputeForwardingRule_forwardingRulePscRecreate

TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample

TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample

TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate

TestAccComputeForwardingRule_forwardingRuleVpcPscExample

TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate

TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample

TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample

TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample

TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate

TestAccComputePacketMirroring_computePacketMirroringFullExample

TestAccComputeRegionBackendService_basic

TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol

TestAccComputeRegionBackendService_ilbUpdateBasic

TestAccComputeRegionBackendService_ilbUpdateFull

TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample

TestAccComputeRegionBackendService_regionBackendServiceCacheExample

TestAccComputeRegionBackendService_regionBackendServiceExternalExample

TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample

TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample

TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample

TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample

TestAccComputeRegionBackendService_subsettingUpdate

TestAccComputeRegionBackendService_withBackendAndIAP

TestAccComputeRegionBackendService_withBackendInternal

TestAccComputeRegionBackendService_withBackendInternalManaged

TestAccComputeRegionBackendService_withBackendMultiNic

TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate

TestAccComputeRegionBackendService_withSecurityPolicy

TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample

TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample

TestAccComputeRegionTargetHttpProxy_update

TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule

TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample

TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample

TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample

TestAccComputeRegionTargetHttpsProxy_update

TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample

TestAccComputeRegionTargetTcpProxy_update

TestAccComputeRegionUrlMap_advanced

TestAccComputeRegionUrlMap_defaultRouteAction_full_update

TestAccComputeRegionUrlMap_ilbPathUpdate

TestAccComputeRegionUrlMap_ilbRouteUpdate

TestAccComputeRegionUrlMap_noPathRulesWithUpdate

TestAccComputeRegionUrlMap_regionUrlMapBasicExample

TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample

TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample

TestAccComputeRegionUrlMap_update_path_matcher

TestAccComputeRoute_routeIlbExample

TestAccComputeRoute_routeIlbVipExample

TestAccComputeServiceAttachment_serviceAttachmentBasicExample

TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate

TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample

TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample

TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample

TestAccPubsubTopic_schema

TestAccVPCAccessConnector_vpcAccessConnectorExample

TestAccVPCAccessConnector_vpcAccessConnectorSharedVpcExample

TestAccVPCAccessConnector_vpcAccessConnectorThroughput

TestAccVPCAccessConnector_vpcAccessConnectorThroughput_usingThroughputOrInstancesLimits

TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

TestAccAppEngineFlexibleAppVersion_update

TestAccAppEngineStandardAppVersion_update

TestAccBigQueryTable_schemaWithRequiredFieldAndView

Get to know how VCR tests work

modular-magician · 2024-07-25T11:57:29Z

Tests analytics

Total tests: 1225
Passed tests: 1051
Skipped tests: 91
Affected tests: 83

Click here to see the affected service packages

bigquery

cloudfunctions

cloudrunv2

compute

pubsub

vpcaccess

activedirectory

appengine

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccVPCAccessConnector_vpcAccessConnectorThroughput_combiningThroughputAndInstancesFields_conflict

Action taken

Found 83 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeBackendService_trafficDirectorUpdateBasic

TestAccComputeBackendService_trafficDirectorUpdateFull

TestAccComputeBackendService_trafficDirectorUpdateLbPolicies

TestAccComputeForwardingRule_forwardingRuleExternallbExample

TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample

TestAccComputeForwardingRule_forwardingRuleHttpLbExample

TestAccComputeForwardingRule_forwardingRuleInternallbExample

TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example

TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6

TestAccComputeForwardingRule_forwardingRuleL3DefaultExample

TestAccComputeForwardingRule_forwardingRulePscRecreate

TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample

TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample

TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate

TestAccComputeForwardingRule_forwardingRuleVpcPscExample

TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate

TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample

TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample

TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample

TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate

TestAccComputePacketMirroring_computePacketMirroringFullExample

TestAccComputeRegionBackendService_basic

TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol

TestAccComputeRegionBackendService_ilbUpdateBasic

TestAccComputeRegionBackendService_ilbUpdateFull

TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample

TestAccComputeRegionBackendService_regionBackendServiceCacheExample

TestAccComputeRegionBackendService_regionBackendServiceExternalExample

TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample

TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample

TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample

TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample

TestAccComputeRegionBackendService_subsettingUpdate

TestAccComputeRegionBackendService_withBackendAndIAP

TestAccComputeRegionBackendService_withBackendInternal

TestAccComputeRegionBackendService_withBackendInternalManaged

TestAccComputeRegionBackendService_withBackendMultiNic

TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate

TestAccComputeRegionBackendService_withSecurityPolicy

TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample

TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample

TestAccComputeRegionTargetHttpProxy_update

TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule

TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample

TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample

TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample

TestAccComputeRegionTargetHttpsProxy_update

TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample

TestAccComputeRegionTargetTcpProxy_update

TestAccComputeRegionUrlMap_advanced

TestAccComputeRegionUrlMap_defaultRouteAction_full_update

TestAccComputeRegionUrlMap_ilbPathUpdate

TestAccComputeRegionUrlMap_ilbRouteUpdate

TestAccComputeRegionUrlMap_noPathRulesWithUpdate

TestAccComputeRegionUrlMap_regionUrlMapBasicExample

TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample

TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample

TestAccComputeRegionUrlMap_update_path_matcher

TestAccComputeRoute_routeIlbExample

TestAccComputeRoute_routeIlbVipExample

TestAccComputeServiceAttachment_serviceAttachmentBasicExample

TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate

TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample

TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample

TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample

TestAccPubsubTopic_schema

TestAccVPCAccessConnector_vpcAccessConnectorExample

TestAccVPCAccessConnector_vpcAccessConnectorSharedVpcExample

TestAccVPCAccessConnector_vpcAccessConnectorThroughput

TestAccVPCAccessConnector_vpcAccessConnectorThroughput_usingThroughputOrInstancesLimits

TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

TestAccAppEngineFlexibleAppVersion_update

TestAccAppEngineStandardAppVersion_update

TestAccBigQueryTable_schemaWithRequiredFieldAndView

TestAccCloudRunV2Job_cloudrunv2JobFullUpdate

TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample

TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate

TestAccCloudRunV2Service_cloudrunv2ServiceGRPCProbesUpdate

TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample

Get to know how VCR tests work

modular-magician · 2024-07-25T12:17:44Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryTable_schemaWithRequiredFieldAndView[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceGRPCProbesUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateBasic[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateFull[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateLbPolicies[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Debug log]
TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeRegionBackendService_basic[Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Debug log]
TestAccComputeRegionBackendService_ilbUpdateBasic[Debug log]
TestAccComputeRegionBackendService_ilbUpdateFull[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceCacheExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample[Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Debug log]
TestAccComputeRegionBackendService_withBackendAndIAP[Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Debug log]
TestAccComputeRegionBackendService_withSecurityPolicy[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpProxy_update[Debug log]
TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_update[Debug log]
TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample[Debug log]
TestAccComputeRegionTargetTcpProxy_update[Debug log]
TestAccComputeRegionUrlMap_advanced[Debug log]
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]
TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log]
TestAccComputeRegionUrlMap_ilbRouteUpdate[Debug log]
TestAccComputeRegionUrlMap_noPathRulesWithUpdate[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapBasicExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample[Debug log]
TestAccComputeRegionUrlMap_update_path_matcher[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Debug log]
TestAccPubsubTopic_schema[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorExample[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorSharedVpcExample[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorThroughput[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorThroughput_usingThroughputOrInstancesLimits[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-07-25T12:27:00Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryTable_schemaWithRequiredFieldAndView[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceGRPCProbesUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateBasic[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateFull[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateLbPolicies[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Debug log]
TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeRegionBackendService_basic[Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Debug log]
TestAccComputeRegionBackendService_ilbUpdateBasic[Debug log]
TestAccComputeRegionBackendService_ilbUpdateFull[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceCacheExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample[Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Debug log]
TestAccComputeRegionBackendService_withBackendAndIAP[Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Debug log]
TestAccComputeRegionBackendService_withSecurityPolicy[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpProxy_update[Debug log]
TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_update[Debug log]
TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample[Debug log]
TestAccComputeRegionTargetTcpProxy_update[Debug log]
TestAccComputeRegionUrlMap_advanced[Debug log]
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]
TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log]
TestAccComputeRegionUrlMap_ilbRouteUpdate[Debug log]
TestAccComputeRegionUrlMap_noPathRulesWithUpdate[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapBasicExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample[Debug log]
TestAccComputeRegionUrlMap_update_path_matcher[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Debug log]
TestAccPubsubTopic_schema[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorExample[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorSharedVpcExample[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorThroughput[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorThroughput_usingThroughputOrInstancesLimits[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

github-actions · 2024-07-25T19:43:30Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-07-25T19:47:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 13 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 5 files changed, 13 insertions(+), 5 deletions(-))

modular-magician · 2024-07-25T19:50:01Z

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

activedirectory

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

abd-goog · 2024-07-26T10:56:19Z

@slevenick could you please review this PR, since you would already have context from our previous email conversation?

…udAD

modular-magician · 2024-07-26T13:22:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 26 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 6 files changed, 26 insertions(+), 5 deletions(-))

modular-magician · 2024-07-26T13:25:30Z

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

activedirectory

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

slevenick

I'm not seeing this change actually do anything in the generated code. Have you seen this work locally?

abd-goog · 2024-07-29T09:27:30Z

I'm not seeing this change actually do anything in the generated code. Have you seen this work locally?

My bad, uncommited changes on local. Updated PR. Thanks

modular-magician · 2024-07-29T09:37:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 54 insertions(+), 144 deletions(-))
google-beta provider: Diff ( 8 files changed, 54 insertions(+), 144 deletions(-))

modular-magician · 2024-07-29T09:39:58Z

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

activedirectory

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

mmv1/templates/terraform/custom_delete/active_directory_domain.erb

...hird_party/terraform/services/activedirectory/resource_active_directory_domain_trust_test.go

modular-magician · 2024-07-30T17:57:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 54 insertions(+), 145 deletions(-))
google-beta provider: Diff ( 8 files changed, 54 insertions(+), 145 deletions(-))

modular-magician · 2024-07-30T18:00:30Z

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

activedirectory

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

add deletion_protection field to cloudAD domain

146e553

abd-goog changed the base branch from main to FEATURE-BRANCH-major-release-6.0.0 July 25, 2024 11:15

modular-magician added the service/terraform label Jul 25, 2024

test var override not needed

9412799

abd-goog marked this pull request as ready for review July 25, 2024 19:42

github-actions bot requested a review from BBBmau July 25, 2024 19:43

abd-goog marked this pull request as draft July 25, 2024 19:46

abd-goog marked this pull request as ready for review July 25, 2024 20:04

abd-goog and others added 2 commits July 26, 2024 17:50

add release notes

63c9937

Merge branch 'FEATURE-BRANCH-major-release-6.0.0' into Tags-R2401-Clo…

23ecf01

…udAD

slevenick requested changes Jul 26, 2024

View reviewed changes

BBBmau removed their request for review July 26, 2024 15:46

add delete custom overrides

d9be946

github-actions bot requested a review from slevenick July 29, 2024 09:26

slevenick requested changes Jul 30, 2024

View reviewed changes

mmv1/templates/terraform/custom_delete/active_directory_domain.erb Outdated Show resolved Hide resolved

...hird_party/terraform/services/activedirectory/resource_active_directory_domain_trust_test.go Outdated Show resolved Hide resolved

move the logic to pre-delete

d49960a

github-actions bot requested a review from slevenick July 30, 2024 17:46

slevenick approved these changes Jul 30, 2024

View reviewed changes

slevenick merged commit b65acdb into GoogleCloudPlatform:FEATURE-BRANCH-major-release-6.0.0 Jul 30, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add deletion_protection field to CloudAD domain resource #11256

Add deletion_protection field to CloudAD domain resource #11256

abd-goog commented Jul 25, 2024 •

edited by slevenick

Loading

modular-magician commented Jul 25, 2024

modular-magician commented Jul 25, 2024

modular-magician commented Jul 25, 2024

modular-magician commented Jul 25, 2024

modular-magician commented Jul 25, 2024

modular-magician commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

modular-magician commented Jul 25, 2024

modular-magician commented Jul 25, 2024

abd-goog commented Jul 26, 2024

modular-magician commented Jul 26, 2024

modular-magician commented Jul 26, 2024

slevenick left a comment

abd-goog commented Jul 29, 2024 •

edited

Loading

modular-magician commented Jul 29, 2024

modular-magician commented Jul 29, 2024

modular-magician commented Jul 30, 2024

modular-magician commented Jul 30, 2024

Add deletion_protection field to CloudAD domain resource #11256

Add deletion_protection field to CloudAD domain resource #11256

Conversation

abd-goog commented Jul 25, 2024 • edited by slevenick Loading

modular-magician commented Jul 25, 2024

Diff report

Breaking Change(s) Detected

modular-magician commented Jul 25, 2024

Diff report

Breaking Change(s) Detected

modular-magician commented Jul 25, 2024

Tests analytics

Action taken

modular-magician commented Jul 25, 2024

Tests analytics

Action taken

modular-magician commented Jul 25, 2024

modular-magician commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

modular-magician commented Jul 25, 2024

Diff report

modular-magician commented Jul 25, 2024

Tests analytics

abd-goog commented Jul 26, 2024

modular-magician commented Jul 26, 2024

Diff report

modular-magician commented Jul 26, 2024

Tests analytics

slevenick left a comment

Choose a reason for hiding this comment

abd-goog commented Jul 29, 2024 • edited Loading

modular-magician commented Jul 29, 2024

Diff report

modular-magician commented Jul 29, 2024

Tests analytics

modular-magician commented Jul 30, 2024

Diff report

modular-magician commented Jul 30, 2024

Tests analytics

abd-goog commented Jul 25, 2024 •

edited by slevenick

Loading

abd-goog commented Jul 29, 2024 •

edited

Loading