Fix salesforce params specification in google_bigquery_data_transfer_config

[wj-chen]

Fixes hashicorp/terraform-provider-google#18506.

Release Note Template for Downstream PRs (will be copied)

bigquery: fixed an issue preventing certain keys in `params` from being assigned values in `google_bigquery_data_transfer_config`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 87 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 87 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• bigquerydatatransfer

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigqueryDataTransferConfig
• TestAccBigqueryDataTransferConfig_salesforce

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigqueryDataTransferConfig_salesforce[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigqueryDataTransferConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 100 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 100 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 23 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1
Passed tests: 0
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• bigquerydatatransfer

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigqueryDataTransferConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigqueryDataTransferConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 96 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 96 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 19 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1
Passed tests: 1
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• bigquerydatatransfer

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

thanks for the work!