Add Sql Server Timezone Update Support

[stameishiGoogle]

Release Note Template for Downstream PRs (will be copied)

sql: added in-place update support for `settings.time_zone` in `google_sql_database_instance` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 69 insertions(+))
google-beta provider: Diff ( 2 files changed, 69 insertions(+))

[modular-magician]

Tests analytics

Total tests: 95
Passed tests: 80
Skipped tests: 14
Affected tests: 1

Click here to see the affected service packages

• sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSqlDatabaseInstance_SqlServerTimezone

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSqlDatabaseInstance_SqlServerTimezone[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[shuyama1]

We'll need to remove ForceNew: true from time_zone, otherwise, Terraform will always delete/recreate the resource if time_zone is changed.

[shuyama1]

This test only checks the creation/deletion of the resource. https://googlecloudplatform.github.io/magic-modules/develop/test/test/#add-an-update-test should cover more details on update tests. Please let me know if you have any questions adding the tests

[shuyama1]

Thanks for the update. Would you mind rebasing your PR to resolve the merge conflicts and add an update test for the field? See #11202 (comment) for update test details. Thank you!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 106 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 106 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 97
Passed tests: 81
Skipped tests: 14
Affected tests: 2

Click here to see the affected service packages

• sql

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSqlDatabaseInstance_SqlServerTimezone
• TestAccSqlServerTimezone_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSqlDatabaseInstance_SqlServerTimezone[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSqlServerTimezone_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[shuyama1]

The VCR test failed with error:

 vcr_utils.go:152: Step 3/4 error: Error running apply: exit status 1
        
        Error: Error, failed to update instance settings for : googleapi: Error 400: Invalid request: Time zone cannot be changed after an instance is created., invalid
        
          with google_sql_database_instance.instance,
          on terraform_plugin_test.tf line 2, in resource "google_sql_database_instance" "instance":
           2: resource "google_sql_database_instance" "instance" {

Do you happen to know if in-place update is fully supported for the time_zone now?

The unit tests failed at lint checks. Details at https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/10171954004/job/28133790678?pr=11202

Please let me know if you need help with debugging the issues.

[shuyama1]

@stameishiGoogle from you GH account name, I assume that you're a googler. If so, you can follow the internal instruction to get your account registered so that the tests will get triggered automatically for your PR for faster feedback.

[stameishiGoogle]

Followed the internal instructions to register my account with the Google organization - Also ran gofmt on resource_sql_database_instance_test.go

In place update is not yet fully supported. These changes are currently being worked on

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 104 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 104 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 98
Passed tests: 83
Skipped tests: 14
Affected tests: 1

Click here to see the affected service packages

• sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSqlServerTimezone_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSqlServerTimezone_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[shuyama1]

Thanks @stameishiGoogle for the update. LGTM overall. We'll need to wait until the feature's fully supported to get the test passed and then get the PR merged after. Please ping me when the feature is released. Thank you!

[github-actions]

@stameishiGoogle, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 104 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 104 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 98
Passed tests: 83
Skipped tests: 14
Affected tests: 1

Click here to see the affected service packages

• sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSqlServerTimezone_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSqlServerTimezone_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[stameishiGoogle]

As of this morning, the feature should be fully rolled out! @shuyama1

[shuyama1]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 79 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 79 insertions(+), 1 deletion(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 79 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 79 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 97
Passed tests: 82
Skipped tests: 14
Affected tests: 1

Click here to see the affected service packages

• sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 97
Passed tests: 82
Skipped tests: 14
Affected tests: 1

Click here to see the affected service packages

• sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test