Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cloudrunv2 containers' env a set #11199

Conversation

yanweiguo
Copy link
Member

Fix hashicorp/terraform-provider-google#17607

This is a redo of #10214

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: retyped `containers.env` to SET from ARRAY for `google_cloud_run_v2_service` and `google_cloud_run_v2_job`.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 106 insertions(+), 94 deletions(-))
google-beta provider: Diff ( 2 files changed, 106 insertions(+), 94 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field template.containers.env changed from TypeList to TypeSet on google_cloud_run_v2_service - reference
  • Field template.template.containers.env changed from TypeList to TypeSet on google_cloud_run_v2_job - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 43
Passed tests: 40
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Job_cloudrunv2JobFullUpdate
  • TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate
  • TestAccCloudRunV2Service_cloudrunv2ServiceGcsVolume

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceGcsVolume[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Copy link

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@yanweiguo
Copy link
Member Author

Added upgrade guide as well.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 121 insertions(+), 94 deletions(-))
google-beta provider: Diff ( 3 files changed, 121 insertions(+), 94 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field template.containers.env changed from TypeList to TypeSet on google_cloud_run_v2_service - reference
  • Field template.template.containers.env changed from TypeList to TypeSet on google_cloud_run_v2_job - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 43
Passed tests: 43
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • cloudrunv2

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants