Added update support to sslPolicy field in region_target_https_proxy

[matheusaleixo-cit]

Adds support to update "ssl_policy" field in "compute_region_target_https_proxy" via the PATCH endpoint, removing its ForceNew flag, as well as related tests;

Fixes: hashicorp/terraform-provider-google#16963

Release Note Template for Downstream PRs (will be copied)

compute: added update support to 'ssl_policy' field in 'compute_region_target_https_proxy' resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 361 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 361 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 953
Passed tests: 876
Skipped tests: 74
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule|TestAccComputeRegionTargetHttpsProxy_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule[Debug log]
TestAccComputeRegionTargetHttpsProxy_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[slevenick]

Just a small question in the test config. I believe the failing test is unrelated and is failing for all PRs, so it should be safe to ignore

[slevenick]

Why do we need create_before_destroy here?

[matheusaleixo-cit]

After re-testing, those fields don't appear to be as necessary as I expected, I will be removing them.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 353 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 353 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 956
Passed tests: 881
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test