re-enable Dataproc Metastore Federation tests

[NickElliot]

Fixes hashicorp/terraform-provider-google#13710

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 116 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 5 files changed, 613 insertions(+), 4 deletions(-))
Open in Cloud Shell: Diff ( 5 files changed, 128 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 19
Skipped tests: 2
Affected tests: 2

Click here to see the affected service packages

• dataprocmetastore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocMetastoreFederationIamPolicyGenerated|TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataprocMetastoreFederationIamPolicyGenerated[Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 120 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 5 files changed, 617 insertions(+), 4 deletions(-))
Open in Cloud Shell: Diff ( 5 files changed, 130 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 19
Skipped tests: 2
Affected tests: 2

Click here to see the affected service packages

• dataprocmetastore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocMetastoreFederationIamPolicyGenerated|TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataprocMetastoreFederationIamPolicyGenerated[Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 118 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 5 files changed, 615 insertions(+), 4 deletions(-))
Open in Cloud Shell: Diff ( 5 files changed, 129 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 19
Skipped tests: 2
Affected tests: 2

Click here to see the affected service packages

• dataprocmetastore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocMetastoreFederationIamPolicyGenerated|TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataprocMetastoreFederationIamPolicyGenerated[Error message] [Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[SarahFrench]

I'm going to use your PR to test this (hashicorp/terraform-provider-google#13710 (comment)) out, sorry for notification spam

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 591 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 5 files changed, 591 insertions(+), 4 deletions(-))
Open in Cloud Shell: Diff ( 7 files changed, 134 insertions(+), 12 deletions(-))

[modular-magician]

Tests analytics

Total tests: 27
Passed tests: 22
Skipped tests: 2
Affected tests: 3

Click here to see the affected service packages

• dataprocmetastore

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataprocMetastoreFederationIamPolicyGenerated
• TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBigqueryExample
• TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocMetastoreFederationIamPolicyGenerated[Debug log]
TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBigqueryExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[SarahFrench]

Looks like TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample is failing because that example includes:

  network_config {
    consumers {
      subnetwork = google_compute_subnetwork.subnet.id
    }
  }

which I assume is causing the address to be created with that subnet, resulting in failure to delete the subnet.

I think that's a new test failure, so not something to attempt to fix here (though maybe a handwritten test could remove the network_config block as it's last step to enable deletion?).

[SarahFrench]

I'd suggest we re-skip generating tests from the dataproc_metastore_service_private_service_connect example and merge this PR to close the original issue. I can open a new issue specific to the new test failure.

Does that sound ok?

[github-actions]

@NickElliot, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

[NickElliot]

@SarahFrench that sounds good to me, feel free to merge this once those have been done!

[SarahFrench]

Please resume this test being skipped here!

[github-actions]

@NickElliot, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@NickElliot, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@NickElliot, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 2 weekdays.

This notification can be disabled with the disable-automatic-closure label.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 528 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 5 files changed, 528 insertions(+), 4 deletions(-))
Open in Cloud Shell: Diff ( 3 files changed, 5 insertions(+), 12 deletions(-))

[modular-magician]

Tests analytics

Total tests: 26
Passed tests: 18
Skipped tests: 2
Affected tests: 6

Click here to see the affected service packages

• dataprocmetastore

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataprocMetastoreFederationIamBindingGenerated
• TestAccDataprocMetastoreFederationIamMemberGenerated
• TestAccDataprocMetastoreFederationIamPolicyGenerated
• TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBasicExample
• TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBigqueryExample
• TestAccDataprocMetastoreService_dataprocMetastoreServiceEndpointExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocMetastoreFederationIamBindingGenerated[Debug log]
TestAccDataprocMetastoreFederationIamMemberGenerated[Debug log]
TestAccDataprocMetastoreFederationIamPolicyGenerated[Debug log]
TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBasicExample[Debug log]
TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBigqueryExample[Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServiceEndpointExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test