Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASM make hydrate failed #389

Closed
kindomLee opened this issue Sep 14, 2022 · 1 comment · Fixed by #394
Closed

ASM make hydrate failed #389

kindomLee opened this issue Sep 14, 2022 · 1 comment · Fixed by #394
Assignees
@gkcalat

Comments

@kindomLee
Copy link
Contributor

kindomLee commented Sep 14, 2022 •
edited
Loading

asm make file will use asmcli-precheck during the hydrate, where the bash built in commands pushd, popd are used.
This will make the runtime error because of the program default`/bin/sh' is used as the shell.

asmcli: -------------
asmcli: Successfully validated all requirements to install ASM.
pushd upstream && ./istioctl experimental precheck && popd
/bin/sh: 1: pushd: Permission denied
make[1]: *** [Makefile:75: asmcli-precheck] Error 127
gkcalat added a commit to gkcalat/kubeflow-distribution that referenced this issue Sep 27, 2022
@gkcalat
Add shell in asm makefile. Fixes GoogleCloudPlatform#389.
fabf20a
gkcalat added a commit to gkcalat/kubeflow-distribution that referenced this issue Sep 27, 2022
@gkcalat
Add shell in asm makefile. Fixes GoogleCloudPlatform#389.
7138e16
@gkcalat gkcalat mentioned this issue Oct 15, 2022
Merged
8 tasks
zijianjoy pushed a commit that referenced this issue Oct 17, 2022
@gkcalat
Releasing GCP Kubeflow distribution v1.6.1 (#394)
9e45cad 
* Add shell in asm makefile. Fixes #389.

* Upgrade MySQL to 8.0

* Upgrade kfp to v2.0.0-alpha.5

* Update CHANGELOG

* Upgrade upstream to v1.6.1

* Add namespace spcification

* Update changelog and add a comment about CloudSQL

* Increase delay before deleting iap helper workloads to 90 sec

* Upgrade KFP to 2.0.0-alpha.6

* Update changelog

* Remove mysql version from comments

* Fix asmcli installation path

* Fix asmcli installation path

* Fix upstream folder in ASM

* Update upstream folder for asm
gkcalat added a commit that referenced this issue Oct 17, 2022
@gkcalat
Releasing GCP Kubeflow distribution v1.6.1 (#394)
1641d19 
* Add shell in asm makefile. Fixes #389.

* Upgrade MySQL to 8.0

* Upgrade kfp to v2.0.0-alpha.5

* Update CHANGELOG

* Upgrade upstream to v1.6.1

* Add namespace spcification

* Update changelog and add a comment about CloudSQL

* Increase delay before deleting iap helper workloads to 90 sec

* Upgrade KFP to 2.0.0-alpha.6

* Update changelog

* Remove mysql version from comments

* Fix asmcli installation path

* Fix asmcli installation path

* Fix upstream folder in ASM

* Update upstream folder for asm
@gkcalat
Copy link
Contributor

gkcalat commented Oct 17, 2022

Hi @kindomLee!
Thank you for reporting. This issue has been fixed in v1.6.1 release.

gkcalat added a commit that referenced this issue Nov 18, 2022
@richardsliu @zijianjoy
@chensun @gkcalat
Add script to automatically create OAuth clients on GCP (#397)
119795e 
* Add Ablai to be owner of the repo (#388)

* Add persistenceagent deployment patch to fix metrics read error (#393)

* Releasing GCP Kubeflow distribution v1.6.1 (#394)

* Add shell in asm makefile. Fixes #389.

* Upgrade MySQL to 8.0

* Upgrade kfp to v2.0.0-alpha.5

* Update CHANGELOG

* Upgrade upstream to v1.6.1

* Add namespace spcification

* Update changelog and add a comment about CloudSQL

* Increase delay before deleting iap helper workloads to 90 sec

* Upgrade KFP to 2.0.0-alpha.6

* Update changelog

* Remove mysql version from comments

* Fix asmcli installation path

* Fix asmcli installation path

* Fix upstream folder in ASM

* Update upstream folder for asm

* script for autocreating oauth client

Co-authored-by: James Liu <37026441+zijianjoy@users.noreply.github.com>
Co-authored-by: Chen Sun <chensun@users.noreply.github.com>
Co-authored-by: gkcalat <35157096+gkcalat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkcalat gkcalat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Releasing GCP Kubeflow distribution v1.6.1 gkcalat/kubeflow-distribution
2 participants
@kindomLee @gkcalat