This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Updating kubemci list to use kubectl tab writer printer #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Changes Unknown when pulling 15612af on nikhiljindal:printList into ** on GoogleCloudPlatform:master**. |
G-Harmon
approved these changes
Jan 8, 2018
| LoadBalancerName: "lb", | ||
| }, | ||
| }, | ||
| "NAME IP CLUSTERS\nlb \n", |
There was a problem hiding this comment.
would this be easier to encode with "\t" instead of literal tabs?
There was a problem hiding this comment.
Yeah, I wonder the same. It might be more readable to use \t
There was a problem hiding this comment.
The spacing is not the same in every case and its not always "\t". Depends on the length of value. It gets confusing with lots of /t's and spaces.
madhusudancs
reviewed
Jan 9, 2018
| LoadBalancerName: "lb", | ||
| }, | ||
| }, | ||
| "NAME IP CLUSTERS\nlb \n", |
There was a problem hiding this comment.
Yeah, I wonder the same. It might be more readable to use \t
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106
Updating
formatLoadBalancersListto use kubectl's tab writer printer.cc @G-Harmon @csbell @madhusudancs