minor fixes to App Engine Flex Spanner sample #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
frankyn
approved these changes
Jun 30, 2017
averikitsch
pushed a commit
that referenced
this pull request
Oct 27, 2022
…1.0 (#740) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.0.0` -> `26.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-tasks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTguMCIsInVwZGF0ZWRJblZlciI6IjMyLjE1OC4wIn0=-->
9 tasks
averikitsch
pushed a commit
that referenced
this pull request
Oct 28, 2022
…1.0 (#740) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.0.0` -> `26.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-tasks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTguMCIsInVwZGF0ZWRJblZlciI6IjMyLjE1OC4wIn0=-->
averikitsch
pushed a commit
that referenced
this pull request
Nov 1, 2022
…1.0 (#740) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.0.0` -> `26.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-tasks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTguMCIsInVwZGF0ZWRJblZlciI6IjMyLjE1OC4wIn0=-->
9 tasks
Sita04
pushed a commit
that referenced
this pull request
Nov 11, 2022
…web to v2.6.5 (#740) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.springframework.boot:spring-boot-starter-web](https://spring.io/projects/spring-boot) ([source](https://togithub.com/spring-projects/spring-boot)) | `2.6.4` -> `2.6.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>spring-projects/spring-boot</summary> ### [`v2.6.5`](https://togithub.com/spring-projects/spring-boot/releases/v2.6.5) [Compare Source](https://togithub.com/spring-projects/spring-boot/compare/v2.6.4...v2.6.5) #### ⭐ New Features - Add EIGHTEEN to JavaVersion enum [#​30132](https://togithub.com/spring-projects/spring-boot/issues/30132) #### 🐞 Bug Fixes - ConfigurationPropertyName#equals is not symmetric when adapt has removed trailing characters from an element [#​30392](https://togithub.com/spring-projects/spring-boot/issues/30392) - Thymeleaf auto-configuration in a reactive application can fail due to duplicate templateEngine beans [#​30385](https://togithub.com/spring-projects/spring-boot/issues/30385) - server.tomcat.keep-alive-timeout is not applied to HTTP/2 [#​30321](https://togithub.com/spring-projects/spring-boot/issues/30321) - Setting spring.mustache.enabled to false has no effect [#​30256](https://togithub.com/spring-projects/spring-boot/issues/30256) - bootWar is configured eagerly [#​30213](https://togithub.com/spring-projects/spring-boot/issues/30213) - Actuator `@ReadOperation` on Flux cancels request after first element emitted [#​30161](https://togithub.com/spring-projects/spring-boot/issues/30161) - Unnecessary allocations in Prometheus scraping endpoint [#​30125](https://togithub.com/spring-projects/spring-boot/issues/30125) - No metrics are bound for R2DBC ConnectionPools that have been wrapped [#​30100](https://togithub.com/spring-projects/spring-boot/issues/30100) - Condition evaluation report entry for a `@ConditionalOnSingleCandidate` that does not match due to multiple primary beans isn't as clear as it could be [#​30098](https://togithub.com/spring-projects/spring-boot/issues/30098) - Generated password are logged without an "unsuitable for production use" note [#​30070](https://togithub.com/spring-projects/spring-boot/issues/30070) - Dependency management for Netty tcNative is incomplete leading to possible version conflicts [#​30038](https://togithub.com/spring-projects/spring-boot/issues/30038) - Files in META-INF are not found when deploying a Gradle-built executable war to a servlet container [#​30036](https://togithub.com/spring-projects/spring-boot/issues/30036) - Dependency management for Apache Kafka is incomplete [#​30031](https://togithub.com/spring-projects/spring-boot/issues/30031) - spring-boot-configuration-processor fails compilation due to `@DefaultValue` with a long value and generates invalid metadata for byte and short properties with out-of-range default values [#​30022](https://togithub.com/spring-projects/spring-boot/issues/30022) #### 📔 Documentation - Add Apache Kafka to the description of the Messaging section [#​30389](https://togithub.com/spring-projects/spring-boot/issues/30389) - Default value of spring.thymeleaf.reactive.media-types is not documented [#​30387](https://togithub.com/spring-projects/spring-boot/issues/30387) - Clarify type matching that is performed when using `@MockBean` and `@SpyBean` [#​30382](https://togithub.com/spring-projects/spring-boot/issues/30382) - Fix links to Spring Security Reference Guide in Accessing the H2 Console in a Secured Application [#​30349](https://togithub.com/spring-projects/spring-boot/pull/30349) - Document how to access the H2 Console in a secured web application [#​30346](https://togithub.com/spring-projects/spring-boot/issues/30346) - Add Netty in "Enable HTTP Response Compression" [#​30344](https://togithub.com/spring-projects/spring-boot/issues/30344) - Fix JsonSerializer example in reference guide [#​30330](https://togithub.com/spring-projects/spring-boot/issues/30330) - WebSockets section missing in reference guide [#​30231](https://togithub.com/spring-projects/spring-boot/issues/30231) - Include default Dev Tools properties in the reference documentation [#​30166](https://togithub.com/spring-projects/spring-boot/issues/30166) - Document the WebSocket-related exclusions that are required to use Jetty 10 [#​30149](https://togithub.com/spring-projects/spring-boot/issues/30149) - Fix typo [#​30120](https://togithub.com/spring-projects/spring-boot/issues/30120) - Add documentation for spring.profiles.include [#​30114](https://togithub.com/spring-projects/spring-boot/issues/30114) - Document when config data properties are invalid [#​30113](https://togithub.com/spring-projects/spring-boot/issues/30113) - Document the scalar types supported by MapBinder [#​30111](https://togithub.com/spring-projects/spring-boot/issues/30111) - Document how to rely on ServletContext with an embedded container setup [#​30109](https://togithub.com/spring-projects/spring-boot/issues/30109) - Anchor tag for Spring HATEOAS does not redirect properly [#​30106](https://togithub.com/spring-projects/spring-boot/issues/30106) - Clarify that build plugins or the CLI does not have an auto-compile feature [#​30093](https://togithub.com/spring-projects/spring-boot/issues/30093) - Document how to structure configurations so that `@Bean` methods are included in slice tests [#​30091](https://togithub.com/spring-projects/spring-boot/issues/30091) - Remove non-existent spring.data.cassandra.connection.connection-timeout property from the documentation [#​30080](https://togithub.com/spring-projects/spring-boot/issues/30080) - Clarify actuator security documentation [#​30065](https://togithub.com/spring-projects/spring-boot/pull/30065) - Use Gradle's task configuration avoidance APIs in the main reference docs [#​30059](https://togithub.com/spring-projects/spring-boot/issues/30059) - Use Gradle's task configuration avoidance APIs in the Gradle Plugin's reference docs [#​30057](https://togithub.com/spring-projects/spring-boot/issues/30057) - Improve property placeholder documentation to mention environment variables and default values [#​30050](https://togithub.com/spring-projects/spring-boot/issues/30050) - Polish web examples in reference doc [#​30048](https://togithub.com/spring-projects/spring-boot/issues/30048) - Add links to Spring Boot for Apache Geode to the reference documentation [#​30018](https://togithub.com/spring-projects/spring-boot/issues/30018) - Document plugging in custom sanitisation rules with a SanitizingFunction bean [#​29950](https://togithub.com/spring-projects/spring-boot/issues/29950) #### 🔨 Dependency Upgrades - Upgrade to Couchbase Client 3.2.6 [#​30237](https://togithub.com/spring-projects/spring-boot/issues/30237) - Upgrade to Dropwizard Metrics 4.2.9 [#​30238](https://togithub.com/spring-projects/spring-boot/issues/30238) - Upgrade to Groovy 3.0.10 [#​30239](https://togithub.com/spring-projects/spring-boot/issues/30239) - Upgrade to Hibernate 5.6.7.Final [#​30338](https://togithub.com/spring-projects/spring-boot/issues/30338) - Upgrade to Hibernate Validator 6.2.3.Final [#​30241](https://togithub.com/spring-projects/spring-boot/issues/30241) - Upgrade to Jackson Bom 2.13.2 [#​30242](https://togithub.com/spring-projects/spring-boot/issues/30242) - Upgrade to Kafka 3.0.1 [#​30243](https://togithub.com/spring-projects/spring-boot/issues/30243) - Upgrade to Lettuce 6.1.8.RELEASE [#​30339](https://togithub.com/spring-projects/spring-boot/issues/30339) - Upgrade to Log4j2 2.17.2 [#​30244](https://togithub.com/spring-projects/spring-boot/issues/30244) - Upgrade to Logback 1.2.11 [#​30245](https://togithub.com/spring-projects/spring-boot/issues/30245) - Upgrade to Micrometer 1.8.4 [#​30178](https://togithub.com/spring-projects/spring-boot/issues/30178) - Upgrade to Neo4j Java Driver 4.4.5 [#​30326](https://togithub.com/spring-projects/spring-boot/issues/30326) - Upgrade to Netty 4.1.75.Final [#​30246](https://togithub.com/spring-projects/spring-boot/issues/30246) - Upgrade to Netty tcNative 2.0.51.Final [#​30247](https://togithub.com/spring-projects/spring-boot/issues/30247) - Upgrade to R2DBC Bom Arabba-SR13 [#​30340](https://togithub.com/spring-projects/spring-boot/issues/30340) - Upgrade to Reactor 2020.0.17 [#​30176](https://togithub.com/spring-projects/spring-boot/issues/30176) - Upgrade to Spring AMQP 2.4.3 [#​30180](https://togithub.com/spring-projects/spring-boot/issues/30180) - Upgrade to Spring Data 2021.1.3 [#​30179](https://togithub.com/spring-projects/spring-boot/issues/30179) - Upgrade to Spring Framework 5.3.17 [#​30177](https://togithub.com/spring-projects/spring-boot/issues/30177) - Upgrade to Spring Integration 5.5.10 [#​30183](https://togithub.com/spring-projects/spring-boot/issues/30183) - Upgrade to Spring Kafka 2.8.4 [#​30181](https://togithub.com/spring-projects/spring-boot/issues/30181) - Upgrade to Spring Retry 1.3.2 [#​30248](https://togithub.com/spring-projects/spring-boot/issues/30248) - Upgrade to Spring WS 3.1.3 [#​30182](https://togithub.com/spring-projects/spring-boot/issues/30182) - Upgrade to Tomcat 9.0.60 [#​30249](https://togithub.com/spring-projects/spring-boot/issues/30249) #### ❤️ Contributors We'd like to thank all the contributors who worked on this release! - [@​cmabdullah](https://togithub.com/cmabdullah) - [@​fml2](https://togithub.com/fml2) - [@​hpoettker](https://togithub.com/hpoettker) - [@​octylFractal](https://togithub.com/octylFractal) - [@​62mkv](https://togithub.com/62mkv) - [@​m-semnani](https://togithub.com/m-semnani) - [@​izeye](https://togithub.com/izeye) - [@​stokpop](https://togithub.com/stokpop) - [@​larsgrefer](https://togithub.com/larsgrefer) - [@​wonwoo](https://togithub.com/wonwoo) - [@​abelsromero](https://togithub.com/abelsromero) - [@​hak7a3](https://togithub.com/hak7a3) - [@​PPakSang](https://togithub.com/PPakSang) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recaptchaenterprise).
Sita04
pushed a commit
that referenced
this pull request
Nov 15, 2022
…web to v2.6.5 (#740) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.springframework.boot:spring-boot-starter-web](https://spring.io/projects/spring-boot) ([source](https://togithub.com/spring-projects/spring-boot)) | `2.6.4` -> `2.6.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>spring-projects/spring-boot</summary> ### [`v2.6.5`](https://togithub.com/spring-projects/spring-boot/releases/v2.6.5) [Compare Source](https://togithub.com/spring-projects/spring-boot/compare/v2.6.4...v2.6.5) #### ⭐ New Features - Add EIGHTEEN to JavaVersion enum [#​30132](https://togithub.com/spring-projects/spring-boot/issues/30132) #### 🐞 Bug Fixes - ConfigurationPropertyName#equals is not symmetric when adapt has removed trailing characters from an element [#​30392](https://togithub.com/spring-projects/spring-boot/issues/30392) - Thymeleaf auto-configuration in a reactive application can fail due to duplicate templateEngine beans [#​30385](https://togithub.com/spring-projects/spring-boot/issues/30385) - server.tomcat.keep-alive-timeout is not applied to HTTP/2 [#​30321](https://togithub.com/spring-projects/spring-boot/issues/30321) - Setting spring.mustache.enabled to false has no effect [#​30256](https://togithub.com/spring-projects/spring-boot/issues/30256) - bootWar is configured eagerly [#​30213](https://togithub.com/spring-projects/spring-boot/issues/30213) - Actuator `@ReadOperation` on Flux cancels request after first element emitted [#​30161](https://togithub.com/spring-projects/spring-boot/issues/30161) - Unnecessary allocations in Prometheus scraping endpoint [#​30125](https://togithub.com/spring-projects/spring-boot/issues/30125) - No metrics are bound for R2DBC ConnectionPools that have been wrapped [#​30100](https://togithub.com/spring-projects/spring-boot/issues/30100) - Condition evaluation report entry for a `@ConditionalOnSingleCandidate` that does not match due to multiple primary beans isn't as clear as it could be [#​30098](https://togithub.com/spring-projects/spring-boot/issues/30098) - Generated password are logged without an "unsuitable for production use" note [#​30070](https://togithub.com/spring-projects/spring-boot/issues/30070) - Dependency management for Netty tcNative is incomplete leading to possible version conflicts [#​30038](https://togithub.com/spring-projects/spring-boot/issues/30038) - Files in META-INF are not found when deploying a Gradle-built executable war to a servlet container [#​30036](https://togithub.com/spring-projects/spring-boot/issues/30036) - Dependency management for Apache Kafka is incomplete [#​30031](https://togithub.com/spring-projects/spring-boot/issues/30031) - spring-boot-configuration-processor fails compilation due to `@DefaultValue` with a long value and generates invalid metadata for byte and short properties with out-of-range default values [#​30022](https://togithub.com/spring-projects/spring-boot/issues/30022) #### 📔 Documentation - Add Apache Kafka to the description of the Messaging section [#​30389](https://togithub.com/spring-projects/spring-boot/issues/30389) - Default value of spring.thymeleaf.reactive.media-types is not documented [#​30387](https://togithub.com/spring-projects/spring-boot/issues/30387) - Clarify type matching that is performed when using `@MockBean` and `@SpyBean` [#​30382](https://togithub.com/spring-projects/spring-boot/issues/30382) - Fix links to Spring Security Reference Guide in Accessing the H2 Console in a Secured Application [#​30349](https://togithub.com/spring-projects/spring-boot/pull/30349) - Document how to access the H2 Console in a secured web application [#​30346](https://togithub.com/spring-projects/spring-boot/issues/30346) - Add Netty in "Enable HTTP Response Compression" [#​30344](https://togithub.com/spring-projects/spring-boot/issues/30344) - Fix JsonSerializer example in reference guide [#​30330](https://togithub.com/spring-projects/spring-boot/issues/30330) - WebSockets section missing in reference guide [#​30231](https://togithub.com/spring-projects/spring-boot/issues/30231) - Include default Dev Tools properties in the reference documentation [#​30166](https://togithub.com/spring-projects/spring-boot/issues/30166) - Document the WebSocket-related exclusions that are required to use Jetty 10 [#​30149](https://togithub.com/spring-projects/spring-boot/issues/30149) - Fix typo [#​30120](https://togithub.com/spring-projects/spring-boot/issues/30120) - Add documentation for spring.profiles.include [#​30114](https://togithub.com/spring-projects/spring-boot/issues/30114) - Document when config data properties are invalid [#​30113](https://togithub.com/spring-projects/spring-boot/issues/30113) - Document the scalar types supported by MapBinder [#​30111](https://togithub.com/spring-projects/spring-boot/issues/30111) - Document how to rely on ServletContext with an embedded container setup [#​30109](https://togithub.com/spring-projects/spring-boot/issues/30109) - Anchor tag for Spring HATEOAS does not redirect properly [#​30106](https://togithub.com/spring-projects/spring-boot/issues/30106) - Clarify that build plugins or the CLI does not have an auto-compile feature [#​30093](https://togithub.com/spring-projects/spring-boot/issues/30093) - Document how to structure configurations so that `@Bean` methods are included in slice tests [#​30091](https://togithub.com/spring-projects/spring-boot/issues/30091) - Remove non-existent spring.data.cassandra.connection.connection-timeout property from the documentation [#​30080](https://togithub.com/spring-projects/spring-boot/issues/30080) - Clarify actuator security documentation [#​30065](https://togithub.com/spring-projects/spring-boot/pull/30065) - Use Gradle's task configuration avoidance APIs in the main reference docs [#​30059](https://togithub.com/spring-projects/spring-boot/issues/30059) - Use Gradle's task configuration avoidance APIs in the Gradle Plugin's reference docs [#​30057](https://togithub.com/spring-projects/spring-boot/issues/30057) - Improve property placeholder documentation to mention environment variables and default values [#​30050](https://togithub.com/spring-projects/spring-boot/issues/30050) - Polish web examples in reference doc [#​30048](https://togithub.com/spring-projects/spring-boot/issues/30048) - Add links to Spring Boot for Apache Geode to the reference documentation [#​30018](https://togithub.com/spring-projects/spring-boot/issues/30018) - Document plugging in custom sanitisation rules with a SanitizingFunction bean [#​29950](https://togithub.com/spring-projects/spring-boot/issues/29950) #### 🔨 Dependency Upgrades - Upgrade to Couchbase Client 3.2.6 [#​30237](https://togithub.com/spring-projects/spring-boot/issues/30237) - Upgrade to Dropwizard Metrics 4.2.9 [#​30238](https://togithub.com/spring-projects/spring-boot/issues/30238) - Upgrade to Groovy 3.0.10 [#​30239](https://togithub.com/spring-projects/spring-boot/issues/30239) - Upgrade to Hibernate 5.6.7.Final [#​30338](https://togithub.com/spring-projects/spring-boot/issues/30338) - Upgrade to Hibernate Validator 6.2.3.Final [#​30241](https://togithub.com/spring-projects/spring-boot/issues/30241) - Upgrade to Jackson Bom 2.13.2 [#​30242](https://togithub.com/spring-projects/spring-boot/issues/30242) - Upgrade to Kafka 3.0.1 [#​30243](https://togithub.com/spring-projects/spring-boot/issues/30243) - Upgrade to Lettuce 6.1.8.RELEASE [#​30339](https://togithub.com/spring-projects/spring-boot/issues/30339) - Upgrade to Log4j2 2.17.2 [#​30244](https://togithub.com/spring-projects/spring-boot/issues/30244) - Upgrade to Logback 1.2.11 [#​30245](https://togithub.com/spring-projects/spring-boot/issues/30245) - Upgrade to Micrometer 1.8.4 [#​30178](https://togithub.com/spring-projects/spring-boot/issues/30178) - Upgrade to Neo4j Java Driver 4.4.5 [#​30326](https://togithub.com/spring-projects/spring-boot/issues/30326) - Upgrade to Netty 4.1.75.Final [#​30246](https://togithub.com/spring-projects/spring-boot/issues/30246) - Upgrade to Netty tcNative 2.0.51.Final [#​30247](https://togithub.com/spring-projects/spring-boot/issues/30247) - Upgrade to R2DBC Bom Arabba-SR13 [#​30340](https://togithub.com/spring-projects/spring-boot/issues/30340) - Upgrade to Reactor 2020.0.17 [#​30176](https://togithub.com/spring-projects/spring-boot/issues/30176) - Upgrade to Spring AMQP 2.4.3 [#​30180](https://togithub.com/spring-projects/spring-boot/issues/30180) - Upgrade to Spring Data 2021.1.3 [#​30179](https://togithub.com/spring-projects/spring-boot/issues/30179) - Upgrade to Spring Framework 5.3.17 [#​30177](https://togithub.com/spring-projects/spring-boot/issues/30177) - Upgrade to Spring Integration 5.5.10 [#​30183](https://togithub.com/spring-projects/spring-boot/issues/30183) - Upgrade to Spring Kafka 2.8.4 [#​30181](https://togithub.com/spring-projects/spring-boot/issues/30181) - Upgrade to Spring Retry 1.3.2 [#​30248](https://togithub.com/spring-projects/spring-boot/issues/30248) - Upgrade to Spring WS 3.1.3 [#​30182](https://togithub.com/spring-projects/spring-boot/issues/30182) - Upgrade to Tomcat 9.0.60 [#​30249](https://togithub.com/spring-projects/spring-boot/issues/30249) #### ❤️ Contributors We'd like to thank all the contributors who worked on this release! - [@​cmabdullah](https://togithub.com/cmabdullah) - [@​fml2](https://togithub.com/fml2) - [@​hpoettker](https://togithub.com/hpoettker) - [@​octylFractal](https://togithub.com/octylFractal) - [@​62mkv](https://togithub.com/62mkv) - [@​m-semnani](https://togithub.com/m-semnani) - [@​izeye](https://togithub.com/izeye) - [@​stokpop](https://togithub.com/stokpop) - [@​larsgrefer](https://togithub.com/larsgrefer) - [@​wonwoo](https://togithub.com/wonwoo) - [@​abelsromero](https://togithub.com/abelsromero) - [@​hak7a3](https://togithub.com/hak7a3) - [@​PPakSang](https://togithub.com/PPakSang) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recaptchaenterprise).
](https://renovatebot.com){kind=link}
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 18, 2022
…form-v1beta1 to v0.11.0 (#740) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1](https://togithub.com/googleapis/java-) | `0.10.0` -> `0.11.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform).
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
### Migrating samples from [googleapis/java-aiplatform](https://togithub.com/googleapis/java-aiplatform/tree/main/samples) into [java-docs-samples/aiplatform](https://togithub.com/GoogleCloudPlatform/java-docs-samples) --- - feat: initial code generation - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.18 (#2) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.19 (#11) - samples: update pom.xml (s) in the samples dir (#24) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.21 (#14) - test(deps): update dependency junit:junit to v4.13.1 - test(deps): update dependency com.google.truth:truth to v1.1 (#33) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.2 (#38) - samples: ucaip samples batch 3 of 6 (#18) - samples: ucaip batch samples 4 of 6 (#19) - samples: ucaip batch samples 5 of 6 (#20) - samples: ucaip samples batch 6 of 6 (#17) - samples: ucaip sample batch 2 of 6 (#15) - chore: delete ununsed format script (#48) - samples: initial commit and it is missing env vars for testing (#7) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v0.1.0 (#59) - samples(deps): update dependency com.google.cloud:google-cloud-storage to v1.113.3 (#55) - samples(deps): update dependency com.google.protobuf:protobuf-java-util to v4.0.0-rc-2 (#27) - samples: adds custom model, action recognition samples and tests (#111) - feat: adds ValueConverter utility and demo samples (#108) - samples(deps): update dependency com.google.cloud:google-cloud-storage to v1.113.8 (#72) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v0.2.0 (#133) - test(deps): update dependency com.google.truth:truth to v1.1.2 (#138) - samples: adds enhanced library samples (#134) - test(deps): update dependency junit:junit to v4.13.2 (#161) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.9 (#132) - fix: reduces image object detection test resource file size (#154) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.10 (#164) - feat: updates library for v1 service (#157) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.11 (#175) - docs: updates prediction to new hostname (#173) - chore: replaced hard-coded values with env vars (#185) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.12 (#186) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v0.3.0 (#188) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.3.0 (#189) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.14 (#202) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v0.4.0 (#209) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.22 (#223) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.4.0 (#210) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.15 (#232) - samples: updates samples to v1 (1 of 8) (#206) - samples: updates samples to v1 (2 of 8) (#212) - test(teardown): refactored teardown section of test (#254) - test(env var): added missing requireEnv val (#255) - samples: updates samples to v1 (3 of 8) (#215) - samples: updates samples to v1 (5 of 10) (#235) - samples: updates samples to v1 (4 of 10) (#233) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.16 (#334) - chore: Increasing timeout createdataset (#337) - samples: updates samples to v1 (7 of 10) (#238) - samples: updates samples to v1 (6 of 10) (#236) - samples: updates samples to v1 (8 of 8) (#239) - deps: update dependency com.google.cloud:google-cloud-storage to v1.114.0 (#349) - deps: update dependency com.google.code.gson:gson to v2.8.7 (#382) - test(deps): update dependency com.google.truth:truth to v1.1.3 (#383) - chore: changes product name to 'Vertex AI' (#373) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.23 (#399) - deps: update dependency com.google.cloud:google-cloud-storage to v1.115.0 (#396) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v1 (#406) - chore: disabling ITs to reduce cost & resolve quota issue (#421) - deps: update dependency com.google.cloud:google-cloud-storage to v1.117.1 (#422) - test: Refactor teardown (#424) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.5.1 (#428) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v1.0.2 (#427) - deps: update dependency com.google.cloud:google-cloud-storage to v1.118.0 (#440) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.5.2 (#434) - deps: update dependency com.google.cloud:google-cloud-storage to v2 (#610) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2 (#609) - deps: update dependency com.google.cloud:google-cloud-storage to v2.0.1 (#612) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.6.0 (#608) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.0.1 (#616) - deps: update dependency com.google.code.gson:gson to v2.8.8 (#622) - deps: update dependency com.google.cloud:google-cloud-storage to v2.0.2 (#621) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.6.1 (#617) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.0 (#630) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.6.2 (#629) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.0.2 (#628) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.1.0 (#640) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.1 (#644) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.2.0 (#650) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.8.0 (#641) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.2.1 (#660) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.2 (#662) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.8.1 (#661) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.8.2 (#666) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.3 (#667) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.4 (#669) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.5 (#673) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.2.2 (#665) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.8.3 (#678) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.2.3 (#677) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.2.4 (#681) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.6 (#683) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.8.4 (#682) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.7 (#689) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.8 (#696) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.9 (#698) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.3.0 (#702) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.9.0 (#703) - deps: update dependency com.google.code.gson:gson to v2.8.9 (#707) - deps: update dependency com.google.cloud:google-cloud-storage to v2.2.0 (#710) - deps: update dependency com.google.cloud:google-cloud-storage to v2.2.1 (#722) - docs: Added evalId comment to samples (#727) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.10.0 (#733) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.4.0 (#732) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.11.0 (#740) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.5.0 (#739) - deps: update dependency com.google.cloud:google-cloud-storage to v2.2.2 (#747) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.11.2 (#744) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.5.2 (#748) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.24 (#734) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.2.0 (#749) - test: Add null check in teardown (#752) - deps: update dependency com.google.cloud:google-cloud-storage to v2.2.3 (#764) - deps: update dependency com.google.cloud:google-cloud-storage to v2.3.0 (#773) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.11.3 (#762) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.5.3 (#761) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.6.0 (#784) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.12.0 (#782) - deps: update dependency com.google.code.gson:gson to v2.9.0 (#792) - deps: update dependency com.google.cloud:google-cloud-storage to v2.4.0 (#783) - deps: update dependency com.google.cloud:google-cloud-storage to v2.4.4 (#801) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.7.0 (#807) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.13.0 (#808) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.7.1 (#813) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.13.1 (#812) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.7.2 (#819) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.13.2 (#817) - deps: update dependency com.google.cloud:google-cloud-storage to v2.4.5 (#818) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.7.3 (#822) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.13.3 (#823) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.7.4 (#828) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.13.4 (#829) - deps: update dependency com.google.cloud:google-cloud-storage to v2.5.0 (#834) - deps: update dependency com.google.cloud:google-cloud-storage to v2.5.1 (#835) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.0 (#838) - deps: update dependency com.google.cloud:google-cloud-storage to v2.6.0 (#840) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.0 (#839) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.1 (#846) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.1 (#847) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.2 (#852) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.2 (#851) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.3 (#855) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.3 (#856) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.4 (#860) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.4 (#859) - deps: update dependency com.google.cloud:google-cloud-storage to v2.6.1 (#863) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.5 (#868) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.5 (#869) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.6 (#875) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.6 (#874) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.7 (#878) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.7 (#879) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.8 (#882) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.8 (#883) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.9 (#890) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.9 (#889) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.0 (#915) - deps: update dependency com.google.cloud:google-cloud-storage to v2.7.0 (#916) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.0 (#914) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.1 (#919) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.1 (#920) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.2 (#924) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.2 (#923) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.3 (#927) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.3 (#928) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.4 (#932) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.4 (#931) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.5 (#936) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.5 (#935) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.6 (#941) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.6 (#942) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.7 (#953) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.7 (#954) - feat(samples): add create-featurestore sample (#948) - feat(samples): added all entity type samples (#976) - feat(samples): add remaining featurestore api samples (#974) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v3 (#986) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.17.0 (#1003) - deps: update dependency com.google.code.gson:gson to v2.9.1 (#1001) - deps: update dependency com.google.cloud:google-cloud-storage to v2.10.0 (#1004) - feat(samples): add all feature samples (#980) - deps: update dependency com.google.cloud:google-cloud-storage to v2.11.0 (#1005) - feat(samples): add all feature values samples (#981) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 (#1006) - deps: update dependency com.google.cloud:google-cloud-storage to v2.11.1 (#1008) - deps: update dependency com.google.cloud:google-cloud-storage to v2.11.2 (#1010) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 (#1009) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v3.2.0 (#1020) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.18.0 (#1021) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 (#1016) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 (#1026) - deps: update dependency com.google.cloud:google-cloud-storage to v2.11.3 (#1015) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 (#1031) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 (#1040) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 (#1044) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.19.0 (#1051) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v3.3.0 (#1050) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.16.1 (#1046) - deps: update dependency com.google.cloud:google-cloud-storage to v2.12.0 (#1047) - feat(sample): featurestore node updates (#1028) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v3.4.0 (#1085) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.17.0 (#1082) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.20.0 (#1086) - deps: update dependency com.google.cloud:google-cloud-storage to v2.13.0 (#1087) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.17.1 (#1092) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v3.4.1 (#1090) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.20.1 (#1091) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.18.0 (#1113) Fixes #issue > It's a good idea to open an issue first for discussion. - [ ] I have followed [Sample Format Guide](https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md) - [ ] `pom.xml` parent set to latest `shared-configuration` - [ ] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [ ] **Tests** pass: `mvn clean verify` **required** - [ ] **Lint** passes: `mvn -P lint checkstyle:check` **required** - [ ] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only** - [ ] Please **merge** this PR for me once it is approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaning up unused code, fixing bad link