Updates Endpoints Frameworks v2 sample with service management. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds service management and auth dependencies and filters. Uses exec-maven-plugin to generate the swagger spec. Updates README for swagger generation.
googlebot
added
the
cla: yes
| @@ -31,9 +31,21 @@ | |||
| <properties> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
|
|
|||
| <endpoints.framework.version>2.0.0-beta.7</endpoints.framework.version> | |||
There was a problem hiding this comment.
I would hope this changes, but ok.
|
LGTM - with required changes. |
lesv
added
the
do not merge
|
I'm marking LGTM and DO NOT MERGE - until all is ok. |
Current coverage is 48.92% (diff: 100%)@@ master #316 diff @@
==========================================
Files 73 73
Lines 2242 2242
Methods 0 0
Messages 0 0
Branches 158 158
==========================================
Hits 1097 1097
Misses 1115 1115
Partials 30 30
|
|
@tswast FYI - BQ Samples are failing. |
|
Merging. LGTM, and it sounds like this is ready from chat. |
tswast
removed
the
do not merge
minherz
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
charlieyu1996
pushed a commit
that referenced
this pull request
Nov 10, 2022
…4.0 (#316) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `13.3.0` -> `13.4.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-talent).
This was referenced Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds service management and auth dependencies and filters.
Uses exec-maven-plugin to generate the swagger spec.
Updates README for swagger generation.