Adds the Endpoints Frameworks v2 Echo Sample #284

wmwong · 2016-08-12T17:57:34Z

No description provided.

lesv · 2016-08-12T18:20:06Z

endpoints-frameworks-v2/backend/pom.xml

+        <maven.compiler.source>1.7</maven.compiler.source>
+        <maven.compiler.target>1.7</maven.compiler.target>
+
+        <appengine.plugin.version>1.9.40</appengine.plugin.version>


Probably should be the latest one. 1.9.42

Updated to use appengine.sdk.version and also removed appengine.app.version, maven.compiler.* as they are in the parent.

lesv · 2016-08-12T19:48:20Z

endpoints-frameworks-v2/backend/src/main/java/com/example/echo/Echo.java

+  @ApiMethod(
+      httpMethod = ApiMethod.HttpMethod.GET,
+      authenticators = {EspAuthenticator.class},
+      audiences = {"488010225785-6nbu9odsh377sl0r7gp1kvsa1l68ss6u.apps.googleusercontent.com"},


We definitely don't check in things like this. YOUR-SERVICE-ACCOUNT-HERE, or better yet, get it from a setting that maven can set such as a property or envVar that maven does substitution for.

Changed to YOUR_OAUTH_CLIENT_ID.

Used Maven properties for web.xml and appengine-web.xml.

lesv · 2016-08-12T20:03:21Z

A README.md would be helpful. It should point out all the places you need to modify and where you get it.

You might wish to look into maven substitution. If you specify a property in maven, you can access it in some files that are copied as ${propertyName}, similar to bash.

web.xml, appengine-web.xml, come directly to mind for this. That way folks only need to change in one place, and they get what they want.

lesv · 2016-08-12T20:05:43Z

The tech writers will need some tags on important sections. usually

 \\ [start thing]
.
.
\\ [end thing]

…h client id.

wmwong · 2016-08-12T22:07:06Z

This sample is to be used in tandem with our documentation on DevSite. Would it be appropriate to link to the documentation in the README?

Also, could you elaborate on the tags for tech writers. I'm not familiar with what the tech writers might need.

codecov-io · 2016-08-15T18:32:40Z

Current coverage is 48.92% (diff: 100%)

Merging #284 into master will increase coverage by 1.70%

@@             master       #284   diff @@
==========================================
  Files            78         73     -5   
  Lines          2270       2242    -28   
  Methods           0          0          
  Messages          0          0          
  Branches        154        158     +4   
==========================================
+ Hits           1072       1097    +25   
+ Misses         1167       1115    -52   
+ Partials         31         30     -1

Powered by Codecov. Last update 29c223a...81ac335

lesv · 2016-08-15T21:25:42Z

Link - YES, but it's good for the readme to have enough to run it.

TW's will ask you at some point.

lesv · 2016-08-15T21:29:52Z

I'm happy w/ this, before merging we will have to:

change the maven repo. Ok to be -SNAPSHOT, but should be public.
Add the README.md

lesv · 2016-08-22T23:10:49Z

You should probably identify that this is for an App Engine Standard sample in the README. (if not, there are several changes needed in the readme).

lesv · 2016-08-22T23:18:25Z

Also, when we publish this, any chance I can ask you to move it from /endpoints to /appengine/endpoints-frameworks-v2/... ?? It's just nice to keep GAE Standard stuff together.

samples. Moves Endpoints Frameworks v2 sample under appengine. Updates pom.xml. Updates root pom.xml. Updates README to mention App Engine Standard.

wmwong · 2016-08-23T20:07:05Z

Updated the README to include App Engine Standard and also moved the sample to be under /appengine.

lesv · 2016-08-23T21:05:11Z

appengine/endpoints-frameworks-v2/backend/src/main/webapp/WEB-INF/appengine-web.xml

+    <application>${endpoints.project.id}</application>
+    <version>1</version>
+    <threadsafe>true</threadsafe>
+    <vm>false</vm>


remove this.

lesv · 2016-08-23T23:33:35Z

LGTM - once the you change to the pushed artifact.

lesv · 2016-08-25T00:08:13Z

appengine/endpoints-frameworks-v2/backend/README.md

@@ -28,11 +28,11 @@ To build the project:
 To generate the required configuration file `swagger.json`:

 0. Download and unzip the [Endpoints Framework tools
-package](http://search.maven.org/remotecontent?filepath=com/google/endpoints/endpoints-framework-tools/2.0.0-beta.4/endpoints-framework-tools-2.0.0-beta.4.zip).
+package](http://search.maven.org/remotecontent?filepath=com/google/endpoints/endpoints-framework-tools/2.0.0-beta.7/endpoints-framework-tools-2.0.0-beta.7.zip).



I'll ok this if you insist, however:

You could do this from maven and then add a a -Pproperty or -Dflag that causes maven to execute this. There are examples of this runlocal or HelloWorldWrite that would be a better experience for first time users.

It would also be a bit more sustainable.

Thanks for the suggestion. I think we will go with what we have for now. I will create a bug to explore this solution and update the sample.

lesv · 2016-08-25T00:08:29Z

PTAL

lesv · 2016-08-25T03:53:22Z

LGTM

…2.0 (#284) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `13.1.0` -> `13.2.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-errorreporting).

…2.0 (#284) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `13.1.0` -> `13.2.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-vision).

### Migrating samples from [googleapis/java-vision](https://togithub.com/googleapis/java-vision/tree/main/samples) into [java-docs-samples/vision](https://togithub.com/GoogleCloudPlatform/java-docs-samples) --- - samples: Vision v1p1beta1 samples (#951) - samples: IoT MQTT Tests (#966) - samples: Generalized testDetextWebEntitiesIncludeGeoResults. (#976) - samples: Update of Flexible folder and the top-level parent pom. (#1004) - samples: Fix tests due to backend changes (#1081) - samples: Add vision ocr for pdf/tiff (#1078) - samples: Update vision dependency version and fix test. (#1099) - samples: Vision beta samples (#1154) - samples: Vision region tag update (#1182) - samples: Udpate Beta Vision samples to use beta tags (#1184) - samples: Remove unused Vision samples and region tags (#1208) - samples: Beta feature : Vision : PDF/TIFF/GIF document feature detection (#1349) - samples: vision: address flakes due to collisions. (#1458) - samples: Fix failing beta tets (#1592) - feat: make repo releasable, add parent/bom (#1) - chore: update common templates, regenerate tests (#20) - chore(regen): update license year for generated files (#48) - samples: fix generated samples directory (#70) - samples: add scaffold (#84) - chore(deps): update dependency com.google.cloud:libraries-bom to v4.3.0 (#88) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.13 (#92) - samples: docs: update tests that are failing or not cleaning up resources - samples: update shared config (#2443) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.14 (#96) - chore(deps): update dependency com.google.cloud:libraries-bom to v4.4.0 (#97) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.15 (#100) - chore(deps): update dependency com.google.cloud:libraries-bom to v4.4.1 (#101) - chore(deps): update dependency com.google.cloud:libraries-bom to v5 (#110) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.16 (#115) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.17 (#121) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.2.0 (#125) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.3.0 (#129) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.4.0 (#139) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.6.0 (#149) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.18 (#155) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.7.0 (#157) - chore(deps): update dependency com.google.cloud:libraries-bom to v6 (#162) - chore(deps): update dependency com.google.cloud:libraries-bom to v7 (#168) - chore(deps): update dependency com.google.cloud:libraries-bom to v7.0.1 (#176) - chore(deps): update dependency com.google.cloud:libraries-bom to v7.0.2 (#178) - chore(deps): update dependency com.google.cloud:libraries-bom to v8 (#179) - chore(deps): update dependency com.google.cloud:libraries-bom to v8.1.0 (#188) - samples: Cloud Client Vision How-to snippets (#485) - samples: Adds GCS snippets, was blocked by https://goo.gl/uWgYhQ - samples: Fixes checkstyle, 3P libs before java libs - samples: Updates vision to the latest library (#548) - samples: Updates snippets so the API client is created in examples (#572) - samples: Infer project from env - samples: Vision speech upgrade (#641) - samples: Changes http test to point to better hosting. - samples: Use Cloud Storage bucket for web URI test - samples: Style nit - samples: Change test to public GCS bucket. - samples: Change test to environment variable. - samples: updating to latest google-cloud-* dependencies (#723) - samples: Closes image annotator client. - samples: Uses try with resource to ensure client gets closed. - samples: upgrade Guava (#802) - samples: Don't check for location (#809) - samples: Vision v1p1beta1 samples (#951) - samples: Update vision folder. (#999) - samples: Update vision/beta web detection samples to v1 (#1016) - samples: Fix tests for backend changes (#1082) - samples: Update vision dependency version and fix test. (#1099) - samples: Update OCR sample from beta to ga (#1123) - samples: Vision region tag update (#1182) - samples: Vision GA - library update (#1213) - samples: vision: address changes in vision annotations. (#1326) - samples: vision: address flakes due to collisions. (#1458) - samples: Fix failing tests (#1591) - samples: Add vision ocr set endpoint snippets (#1748) - samples: vision: change flaky tests to mocks (#2254) - samples: vision: move samples out of branch (#2298) - samples: vision: move samples out of branch and add clarifying comments (#2297) - samples: fix: region tag (#2312) - samples: vision: makes tests more generic (#2475) - samples: update shared config (#2443) - samples: chore: added comment on try/catch block (#2980) - samples: chore: splitting sample into single files (#3083) - samples: fix test dependencies - samples: fix resources - samples: Vision Product Search (#1161) - samples: Vision region tag update (#1182) - samples: Adding the Product Search tests. (#1195) - samples: Added the Product Search tests and the src file updates (#1196) - samples: Vision Product Search - GA (#1257) - samples: Pdt search updates (#1473) - samples: Purge Products (#1569) - samples: vision: update product search tests (#2378) - samples: vision: use uuid for product search tests - samples: Update ImportProductSetsIT.java - samples: bump timeouts - samples: update shared config (#2443) - samples: fix resources and dependencies - samples: fix resources - chore(deps): update dependency com.google.cloud:libraries-bom to v9 (#207) - chore(deps): update dependency com.google.cloud:libraries-bom to v9.1.0 - chore(deps): update dependency com.google.cloud:libraries-bom to v10 - chore(deps): update dependency com.google.cloud:libraries-bom to v11 - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.21 (#244) - chore(deps): update dependency com.google.cloud:libraries-bom to v12 (#249) - test(deps): update dependency junit:junit to v4.13.1 - chore(deps): update dependency com.google.cloud:libraries-bom to v12.1.0 (#262) - chore(deps): update dependency com.google.cloud:libraries-bom to v13 (#272) - test(deps): update dependency com.google.truth:truth to v1.1 (#274) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.2.0 (#284) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.3.0 (#287) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.4.0 (#297) - chore: moving the rest of the vision samples (#291) - samples(deps): update spring.version to v2.3.5.release (#305) - chore(deps): update dependency com.google.cloud:libraries-bom to v14 (#307) - chore(deps): update dependency com.google.cloud:libraries-bom to v15 (#310) - chore(deps): update dependency com.google.cloud:libraries-bom to v16 (#326) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.2.0 (#357) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.2.1 (#362) - samples(deps): update dependency org.springframework.cloud:spring-cloud-gcp-dependencies to v1.2.6.release (#313) - samples(deps): update spring.version to v2.4.1 (#320) - samples(deps): update spring.version to v2.4.2 (#374) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.4.0 (#373) - test(deps): update dependency junit:junit to v4.13.2 (#397) - test(samples): prevent failure in nightly run by adding retry (#392) - chore(deps): update dependency com.google.cloud:libraries-bom to v17 (#411) - samples(deps): update dependency com.google.cloud:google-cloud-core to v1.94.1 (#405) - samples(deps): update spring.version to v2.4.3 (#402) - samples(deps): update dependency org.springframework.cloud:spring-cloud-gcp-dependencies to v1.2.7.release (#395) - chore(deps): update dependency com.google.cloud:libraries-bom to v18 (#414) - deps: update dependency com.google.cloud:google-cloud-core to v1.94.2 (#423) - chore(deps): update dependency com.google.cloud:libraries-bom to v18.1.0 (#427) - chore(deps): update dependency com.google.cloud:libraries-bom to v19 (#431) - deps: update dependency com.google.cloud:google-cloud-core to v1.94.3 (#428) - chore(deps): update dependency com.google.cloud:libraries-bom to v19.1.0 (#445) - chore(deps): update dependency com.google.cloud:libraries-bom to v19.2.1 (#447) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.22 (#454) - chore(deps): update dependency com.google.cloud:libraries-bom to v20 (#463) - deps: update dependency net.sourceforge.argparse4j:argparse4j to v0.9.0 (#455) - deps: update dependency com.google.cloud:google-cloud-core to v1.94.7 (#441) - deps: update spring.version to v2.4.4 (#448) - deps: update spring.version to v2.4.5 (#474) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.1.0 (#475) - chore: service throttles on public URLs & its known issue. (#477) - deps: update dependency com.google.cloud:google-cloud-core to v1.94.8 (#482) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.2.0 (#487) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.3.0 (#500) - test(deps): update dependency com.google.truth:truth to v1.1.2 (#498) - deps: update dependency org.springframework.cloud:spring-cloud-gcp-dependencies to v1.2.8.release (#497) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.4.0 (#509) - test(deps): update dependency com.google.truth:truth to v1.1.3 (#520) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.5.0 (#519) - deps: update spring.version to v2.5.0 (#516) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.6.0 (#537) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.23 (#536) - deps: update dependency com.google.cloud:google-cloud-core to v1.95.1 (#533) - deps: update dependency com.google.cloud:google-cloud-core to v1.95.2 (#542) - deps: update spring.version to v2.5.1 (#544) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.7.0 (#564) - deps: update spring.version to v2.5.2 (#566) - deps: update dependency com.google.cloud:google-cloud-core to v1.95.4 (#563) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.8.0 (#575) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.9.0 (#586) - deps: update dependency com.google.cloud:google-cloud-core to v2 (#599) - deps: update dependency org.apache.commons:commons-csv to v1.9.0 (#598) - deps: update dependency com.google.cloud:google-cloud-core to v2.0.3 (#611) - deps: update dependency com.google.cloud:google-cloud-core to v2.0.5 (#614) - deps: update spring.version to v2.5.4 (#581) - chore(deps): update dependency com.google.cloud:libraries-bom to v21 (#619) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.0 (#634) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.1 (#641) - chore(deps): update dependency com.google.cloud:libraries-bom to v22 (#650) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.2 (#652) - chore(deps): update dependency com.google.cloud:libraries-bom to v23 (#668) - chore: migrate to owlbot (#663) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.3 (#674) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.4 (#685) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.6 (#692) - deps: update spring.version to v2.5.5 (#703) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.7 (#702) - chore(deps): update dependency com.google.cloud:libraries-bom to v23.1.0 (#715) - deps: update dependency com.google.cloud:google-cloud-core to v2.2.0 (#720) - deps: update spring.version to v2.5.6 (#729) - chore(deps): update dependency com.google.cloud:libraries-bom to v24 (#733) - deps: update dependency com.google.cloud:google-cloud-core to v2.3.0 (#744) - deps: update dependency com.google.cloud:google-cloud-core to v2.3.1 (#746) - deps: update spring.version to v2.6.0 (#749) - deps: update dependency com.google.cloud:google-cloud-core to v2.3.2 (#756) - deps: update dependency com.google.cloud:google-cloud-core to v2.3.3 (#758) - deps: update dependency org.springframework.boot:spring-boot-starter-web to v2.6.1 (#751) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.2.0 (#755) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.0 (#767) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.1 (#769) - deps: update dependency com.google.cloud:google-cloud-core to v2.3.4 (#772) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.2 (#773) - deps: update dependency com.google.cloud:google-cloud-core to v2.3.5 (#779) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.2.0 (#788) - deps: update spring.version to v2.6.3 (#768) - deps: update dependency com.google.cloud:google-cloud-core to v2.4.0 (#797) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.3.0 (#809) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.0 (#804) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.1 (#811) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.3 (#812) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.4 (#816) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.5 (#825) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.6 (#828) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.4.0 (#830) - deps: update dependency org.springframework.boot:spring-boot-maven-plugin to v2.6.4 (#822) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.8 (#840) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.9 (#844) - chore(deps): update dependency com.google.cloud:libraries-bom to v25 (#850) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.10 (#849) - deps: update spring.version to v2.6.5 (#855) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.11 (#860) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.1.0 (#866) - build(deps): bump spring-boot-starter-web in /samples/spring-framework (#867) - deps: update dependency com.google.cloud:google-cloud-core to v2.6.1 (#878) - deps: update spring.version to v2.6.7 (#888) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.2.0 (#891) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.3.0 (#905) - deps: update spring.version to v2.7.0 (#908) - deps: update dependency com.google.cloud:google-cloud-core to v2.7.1 (#906) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.4.0 (#917) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.0 (#920) - deps: update spring.version to v2.7.1 (#925) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.1 (#931) - chore(deps): update dependency com.google.cloud:libraries-bom to v26 (#945) - deps: update spring.version to v2.7.2 (#951) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.6 (#955) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.7 (#958) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.8 (#960) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.0 (#970) - deps: update spring.version to v2.7.3 (#974) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.9 (#973) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.10 (#977) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.1 (#978) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.11 (#980) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.12 (#984) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.2 (#990) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.13 (#992) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.14 (#993) - deps: update spring.version to v2.7.4 (#994) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.18 (#995) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.19 (#1023) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.20 (#1025) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.3 (#1031) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.21 (#1034) Fixes #issue > It's a good idea to open an issue first for discussion. - [ ] I have followed [Sample Format Guide](https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md) - [ ] `pom.xml` parent set to latest `shared-configuration` - [ ] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [ ] **Tests** pass: `mvn clean verify` **required** - [ ] **Lint** passes: `mvn -P lint checkstyle:check` **required** - [ ] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only** - [ ] Please **merge** this PR for me once it is approved.

Adds the Endpoints Frameworks v2 Echo Sample

2a29f6b

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2016

wmwong assigned lesv Aug 12, 2016

lesv reviewed Aug 12, 2016
View reviewed changes

Remove unneeded properties and use appengine.sdk.version.

c7af048

lesv reviewed Aug 12, 2016
View reviewed changes

Use Maven properties to specify project id and replace hardcoded oaut…

f355ee0

…h client id.

wmwong added 3 commits August 12, 2016 17:31

Add comments about the different parts of web.xml.

e97c063

Add more comments to web.xml.

1f0e74e

Update root pom.xml with the correct path for endpoints-frameworks-v2.

602fc0a

lesv added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 16, 2016

wmwong added 3 commits August 18, 2016 16:21

Update versions and remove manual-scaling.

4e9b419

Add README to Endpoints Frameworks v2 sample.

452b6d1

Changes from auto-scaling to basic-scaling.

425886f

Aligns Endpoints Frameworks v2 sample with other App Engine Standard

b8e87af

samples. Moves Endpoints Frameworks v2 sample under appengine. Updates pom.xml. Updates root pom.xml. Updates README to mention App Engine Standard.

lesv reviewed Aug 23, 2016
View reviewed changes

Remove <vm> from appengine-web.xml.

81ac335

Version bump and use framework only.

fd92d81

lesv reviewed Aug 25, 2016
View reviewed changes

lesv merged commit 7cec9ea into master Aug 25, 2016

lesv deleted the endpoints-frameworks-v2-sample branch August 25, 2016 03:54

bourgeoisor pushed a commit that referenced this pull request Nov 11, 2022

adding submit job sample and updating submit job in quickstart (#284)

3f68184

bourgeoisor mentioned this pull request Nov 11, 2022

migrate code from googleapis/java-dataproc #7407

Merged

9 tasks

Shabirmean mentioned this pull request Nov 15, 2022

samples: migrate code from googleapis/java-vision #7428

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds the Endpoints Frameworks v2 Echo Sample #284

Adds the Endpoints Frameworks v2 Echo Sample #284

wmwong commented Aug 12, 2016

lesv Aug 12, 2016

wmwong Aug 12, 2016

lesv Aug 12, 2016 •

edited

Loading

wmwong Aug 12, 2016

wmwong Aug 12, 2016

lesv commented Aug 12, 2016

lesv commented Aug 12, 2016

wmwong commented Aug 12, 2016

codecov-io commented Aug 15, 2016 •

edited

Loading

lesv commented Aug 15, 2016

lesv commented Aug 15, 2016

lesv commented Aug 22, 2016

lesv commented Aug 22, 2016

wmwong commented Aug 23, 2016

lesv Aug 23, 2016

wmwong Aug 23, 2016

lesv commented Aug 23, 2016

lesv Aug 25, 2016

wmwong Aug 25, 2016

lesv commented Aug 25, 2016

lesv commented Aug 25, 2016

Adds the Endpoints Frameworks v2 Echo Sample #284

Adds the Endpoints Frameworks v2 Echo Sample #284

Conversation

wmwong commented Aug 12, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lesv Aug 12, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lesv commented Aug 12, 2016

lesv commented Aug 12, 2016

wmwong commented Aug 12, 2016

codecov-io commented Aug 15, 2016 • edited Loading

Current coverage is 48.92% (diff: 100%)

lesv commented Aug 15, 2016

lesv commented Aug 15, 2016

lesv commented Aug 22, 2016

lesv commented Aug 22, 2016

wmwong commented Aug 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lesv commented Aug 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lesv commented Aug 25, 2016

lesv commented Aug 25, 2016

lesv Aug 12, 2016 •

edited

Loading

codecov-io commented Aug 15, 2016 •

edited

Loading