Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding CreateCluster sample for Dataproc #1734

Merged
merged 15 commits into from
Nov 15, 2019
Merged

Conversation

bradmiro
Copy link
Contributor

This PR adds a sample that creates a Dataproc cluster using the Java Client Library.

@bradmiro bradmiro requested review from lesv and a team November 14, 2019 00:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2019
dataproc/pom.xml Outdated Show resolved Hide resolved
dataproc/src/main/java/CreateCluster.java Outdated Show resolved Hide resolved
dataproc/src/main/java/CreateCluster.java Outdated Show resolved Hide resolved
dataproc/pom.xml Show resolved Hide resolved
dataproc/pom.xml Outdated Show resolved Hide resolved
dataproc/src/main/java/CreateCluster.java Outdated Show resolved Hide resolved
dataproc/src/main/java/CreateCluster.java Outdated Show resolved Hide resolved
dataproc/src/test/java/CreateClusterTest.java Outdated Show resolved Hide resolved
dataproc/src/test/java/CreateClusterTest.java Outdated Show resolved Hide resolved
dataproc/src/test/java/CreateClusterTest.java Outdated Show resolved Hide resolved
@bradmiro
Copy link
Contributor Author

Most of @kurtisvg's suggestions fixed with these commits. I left a comment on one suggestion.

Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the one comment

dataproc/pom.xml Outdated Show resolved Hide resolved
dataproc/src/main/java/CreateCluster.java Show resolved Hide resolved
@bradmiro bradmiro merged commit d1ac030 into master Nov 15, 2019
@bradmiro bradmiro deleted the dataproc-samples branch November 15, 2019 20:55
bourgeoisor pushed a commit that referenced this pull request Nov 11, 2022
* refactored and added tags to infinite speech streaming sample (#1605)

* Changed 'main' region tag

* Removed extra lines around tags and changed client import to v1

* Create dataproc directory and add CreateCluster sample

* reverting changes to speech infinite streaming sample

* Added java versions to pom

* Several changes to file formatting as per request in the PR

* Added comments to exceptions in  CreateCluster, expanded exceptions and femoved endpoint configuring in CreateClusterTest.java

* Fixed version for parent config

* Added clarity to futures requests by expanding variables

* Fixed linting errors

* Fixed import ordering

* Moved exceptions to function level in dataproc create cluster sample + test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants