Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for the Developer Portal #1084

Merged
merged 4 commits into from
Apr 19, 2018
Merged

Updates for the Developer Portal #1084

merged 4 commits into from
Apr 19, 2018

Conversation

navinger
Copy link
Contributor

@navinger navinger commented Apr 5, 2018

Updates so the sample API can be used easily in the Developer Portal.
-- In schemes, it has to be "http" so that you can test the echo API in the Developer Portal.
-- In the echoMessage definition, adding type: "object" provides a better user experience in the Developer Portal.

Updates so the sample API can be used easily in the Developer Portal. 
-- In schemes, it has to be "http" so that you can test the echo API in the Developer Portal. 
-- In the echoMessage definition, adding type: "object" provides a better user experience in the Developer Portal.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2018
@simonz130 simonz130 self-requested a review April 17, 2018 05:18
@simonz130 simonz130 requested review from lesv and jabubake April 17, 2018 05:18
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@@ -25,7 +25,9 @@ consumes:
produces:
- "application/json"
schemes:
- "https"
# Uncomment the next line if you configure SSL for this API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And comment out the http line

@navinger
Copy link
Contributor Author

I asked an engineer on the developer portal team if you really do have to comment out the http line, and his response was:
"no, multiple schemes are OK
it's not either/or"

Please merge this change to master. You can't test the sample code in the Developer Portal without this change.

@lesv
Copy link
Contributor

lesv commented Apr 19, 2018

SGTM - though typically users want to lock down http when they use https. We are encouraging folks to go http only.

@lesv
Copy link
Contributor

lesv commented Apr 19, 2018

@dpebot merge when green

@dpebot
Copy link
Contributor

dpebot commented Apr 19, 2018

Okay! I'll merge when all statuses are green and all reviewers approve.

@dpebot dpebot self-assigned this Apr 19, 2018
@lesv lesv merged commit 2514e09 into GoogleCloudPlatform:master Apr 19, 2018
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
…#1084)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.13` -> `2.8.14` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/compatibility-slim/2.8.13)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/confidence-slim/2.8.13)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.14`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;2814-httpsgithubcomgoogleapisjava-corecomparev2813v2814-2022-09-20)

[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.13...v2.8.14)

##### Dependencies

-   Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.3 ([#&#8203;922](https://togithub.com/googleapis/java-core/issues/922)) ([96b5b4e](https://togithub.com/googleapis/java-core/commit/96b5b4e00004c28cd2d726c2161e94778f6a1c01))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTguMSIsInVwZGF0ZWRJblZlciI6IjMyLjE5OC4xIn0=-->
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
…#1084)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.13` -> `2.8.14` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/compatibility-slim/2.8.13)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/confidence-slim/2.8.13)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.14`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;2814-httpsgithubcomgoogleapisjava-corecomparev2813v2814-2022-09-20)

[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.13...v2.8.14)

##### Dependencies

-   Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.3 ([#&#8203;922](https://togithub.com/googleapis/java-core/issues/922)) ([96b5b4e](https://togithub.com/googleapis/java-core/commit/96b5b4e00004c28cd2d726c2161e94778f6a1c01))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTguMSIsInVwZGF0ZWRJblZlciI6IjMyLjE5OC4xIn0=-->
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
…#1084)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.13` -> `2.8.14` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/compatibility-slim/2.8.13)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/confidence-slim/2.8.13)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.14`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;2814-httpsgithubcomgoogleapisjava-corecomparev2813v2814-2022-09-20)

[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.13...v2.8.14)

##### Dependencies

-   Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.3 ([#&#8203;922](https://togithub.com/googleapis/java-core/issues/922)) ([96b5b4e](https://togithub.com/googleapis/java-core/commit/96b5b4e00004c28cd2d726c2161e94778f6a1c01))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTguMSIsInVwZGF0ZWRJblZlciI6IjMyLjE5OC4xIn0=-->
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
…#1084)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.13` -> `2.8.14` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/compatibility-slim/2.8.13)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.14/confidence-slim/2.8.13)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.14`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;2814-httpsgithubcomgoogleapisjava-corecomparev2813v2814-2022-09-20)

[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.13...v2.8.14)

##### Dependencies

-   Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.3 ([#&#8203;922](https://togithub.com/googleapis/java-core/issues/922)) ([96b5b4e](https://togithub.com/googleapis/java-core/commit/96b5b4e00004c28cd2d726c2161e94778f6a1c01))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTguMSIsInVwZGF0ZWRJblZlciI6IjMyLjE5OC4xIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants