Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off some expected logging messages in tests #2782

Merged
merged 4 commits into from
Feb 8, 2018
Merged

turn off some expected logging messages in tests #2782

merged 4 commits into from
Feb 8, 2018

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 8, 2018

silence some warnings for #2716
I'm debating how generic we should make this.

@codecov
Copy link

codecov bot commented Feb 8, 2018

Codecov Report

Merging #2782 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2782      +/-   ##
============================================
+ Coverage     68.31%   68.33%   +0.01%     
- Complexity     2517     2518       +1     
============================================
  Files           347      347              
  Lines         12215    12215              
  Branches       1466     1466              
============================================
+ Hits           8345     8347       +2     
+ Misses         3283     3282       -1     
+ Partials        587      586       -1
Impacted Files Coverage Δ Complexity Δ
...ow/ui/preferences/RunOptionsDefaultsComponent.java 77.09% <0%> (+0.72%) 41% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2425972...21d2561. Read the comment docs.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't thought of downgrading the logging level.

@After
public void tearDown() throws SAXException, IOException, CoreException {
Logger logger = Logger.getLogger(ArtifactRetriever.class.getName());
logger.setLevel(Level.WARNING);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use logger.setLevel(null) so that it inherits from the parent (which ws probably the previous level)?

@elharo elharo merged commit f070b08 into master Feb 8, 2018
@elharo elharo deleted the i2716 branch February 8, 2018 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants