Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding support for Spanner with PG Dialect in Database Retriever Service #469

Merged

Conversation

gauravpurohit06
Copy link
Contributor

Adding support for Spanner with PG Dialect in Database Retriever Service.

@Yuan325
Copy link
Collaborator

Yuan325 commented Aug 21, 2024

/gcbrun

@Yuan325
Copy link
Collaborator

Yuan325 commented Aug 27, 2024

/gcbrun

Copy link
Collaborator

@Yuan325 Yuan325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you also update the docs here for pg?

@Yuan325
Copy link
Collaborator

Yuan325 commented Aug 27, 2024

/gcbrun

@Yuan325 Yuan325 self-requested a review August 27, 2024 04:58
@Yuan325
Copy link
Collaborator

Yuan325 commented Aug 27, 2024

/gcbrun

@Yuan325
Copy link
Collaborator

Yuan325 commented Aug 27, 2024

/gcbrun

@Yuan325
Copy link
Collaborator

Yuan325 commented Aug 28, 2024

/gcbrun

Copy link
Collaborator

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on Yuan's LGTM

@kurtisvg
Copy link
Collaborator

/gcbrun

@kurtisvg kurtisvg enabled auto-merge (squash) August 28, 2024 17:11
@kurtisvg kurtisvg merged commit 47ff11e into GoogleCloudPlatform:main Aug 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants