Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from gcsfuse-prelaunch #2906

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

gargnitingoogle
Copy link
Collaborator

First attempt

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle self-assigned this Jan 17, 2025
@kislaykishore kislaykishore requested review from a team, BrennaEpp and tritone and removed request for a team, BrennaEpp and tritone January 17, 2025 05:41
@kislaykishore kislaykishore requested review from a team and removed request for kislaykishore and vadlakondaswetha January 17, 2025 05:42
internal/cache/file/downloader/job.go Outdated Show resolved Hide resolved
internal/cache/file/downloader/job_test.go Show resolved Hide resolved
internal/fs/hns_bucket_test.go Outdated Show resolved Hide resolved
internal/gcsx/append_object_creator.go Outdated Show resolved Hide resolved
internal/gcsx/random_reader_test.go Show resolved Hide resolved
internal/gcsx/syncer.go Outdated Show resolved Hide resolved
internal/monitor/bucket.go Outdated Show resolved Hide resolved
internal/monitor/bucket.go Outdated Show resolved Hide resolved
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/merge-prelaunch-repo/v1 branch from 50ee334 to f0c05f4 Compare January 17, 2025 13:16
internal/monitor/bucket.go Outdated Show resolved Hide resolved
internal/monitor/gcs_request.go Outdated Show resolved Hide resolved
@@ -28,7 +28,7 @@ jobs:
matrix:
go: [ 1.23.x ]
runs-on: ubuntu-latest
timeout-minutes: 15
timeout-minutes: 30
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept it from what we had in prelaunch repo. if it passes under 15 minutes, I'll put it back to 15 min.

internal/cache/file/downloader/job.go Outdated Show resolved Hide resolved
internal/fs/inode/file.go Outdated Show resolved Hide resolved
internal/monitor/bucket.go Outdated Show resolved Hide resolved
internal/monitor/bucket.go Outdated Show resolved Hide resolved
internal/gcsx/append_object_creator.go Outdated Show resolved Hide resolved
internal/cache/file/downloader/job_test.go Show resolved Hide resolved
internal/fs/inode/hns_dir_test.go Show resolved Hide resolved
internal/gcsx/random_reader_test.go Outdated Show resolved Hide resolved
internal/monitor/bucket.go Outdated Show resolved Hide resolved
@kislaykishore kislaykishore requested a review from a team January 17, 2025 14:37
@gargnitingoogle
Copy link
Collaborator Author

@vipnydav please check that your write-failure related changes are all unaffected or properly transformed in this PR.

@gargnitingoogle gargnitingoogle marked this pull request as ready for review January 17, 2025 17:16
@gargnitingoogle gargnitingoogle requested a review from a team as a code owner January 17, 2025 17:16
@gargnitingoogle gargnitingoogle added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants