-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge changes from gcsfuse-prelaunch #2906
Open
gargnitingoogle
wants to merge
35
commits into
master
Choose a base branch
from
gargnitin/merge-prelaunch-repo/v1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4,300
−1,012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First attempt
ashmeenkaur
reviewed
Jan 17, 2025
gargnitingoogle
requested review from
abhishek10004,
raj-prince,
Tulsishah,
ashmeenkaur and
anushka567
January 17, 2025 05:41
kislaykishore
requested review from
a team,
BrennaEpp and
tritone
and removed request for
a team,
BrennaEpp and
tritone
January 17, 2025 05:41
kislaykishore
requested review from
a team
and removed request for
kislaykishore and
vadlakondaswetha
January 17, 2025 05:42
gargnitingoogle
commented
Jan 17, 2025
gargnitingoogle
force-pushed
the
gargnitin/merge-prelaunch-repo/v1
branch
from
January 17, 2025 13:16
50ee334
to
f0c05f4
Compare
gargnitingoogle
commented
Jan 17, 2025
@@ -28,7 +28,7 @@ jobs: | |||
matrix: | |||
go: [ 1.23.x ] | |||
runs-on: ubuntu-latest | |||
timeout-minutes: 15 | |||
timeout-minutes: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept it from what we had in prelaunch repo. if it passes under 15 minutes, I'll put it back to 15 min.
tools/integration_tests/read_large_files/testdata/write_content_of_fix_size_in_file.sh
Outdated
Show resolved
Hide resolved
gargnitingoogle
commented
Jan 17, 2025
@vipnydav please check that your write-failure related changes are all unaffected or properly transformed in this PR. |
gargnitingoogle
added
execute-perf-test
Execute performance test in PR
execute-integration-tests
Run only integration tests
labels
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
execute-integration-tests
Run only integration tests
execute-perf-test
Execute performance test in PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt
Description
Link to the issue in case of a bug fix.
NA
Testing details