datastore: Introduce Key type #101

rakyll · 2014-08-07T21:43:56Z

Related to #73 and #39.

stephenplusplus · 2014-08-07T21:56:23Z

Looks awesome!

lib/datastore/entity.js

@@ -43,6 +43,12 @@ var signToOrderDict = {
  '+':  'ASCENDING'
 };

+function Key(path) {
+  this.path_ = path;


rakyll · 2014-08-07T22:32:37Z

No more square brackets! I keep supporting an array path for those who might find it handier to create paths programmatically. JS doesn't have syntactic sugar for variadic arguments :(

Regression tests are fixed. PTAL.

regression/datastore.js

-      var postKeyId = '123456789';
-
-      ds.save({ key: ['Post', postKeyId], data: post }, function(err, key) {
+      var postKey = datastore.Key('Post', 123456789)


rakyll · 2014-08-07T22:48:08Z

Fixed README, PTAL.

lib/datastore/index.js

+      return new entity.Key(path);
+    }
+    return new entity.Key([].slice.call(arguments));
+  },


stephenplusplus · 2014-08-07T23:02:04Z

Found a shortcut you can use (noted above), but everything looks good.

Just thinking out loud, feel free to inform me why this may not be a good idea... where keys are required (e.g. dataset.get()), would it be beneficial not to require the use of datastore.key(), instead accepting the array we do currently, then creating a new Key object behind the scenes from it?

rakyll · 2014-08-07T23:50:36Z

would it be beneficial not to require the use of datastore.key()

Optionally, we could support that. It could be a little bit confusing for multi get/save/delete operations. On the other hand, most of the time, people won't need to construct a key by hand, rather use an existing key instance retrieved via querying.

I'm more concerned about incomplete keys, they are pretty cryptic.

stephenplusplus · 2014-08-08T00:14:04Z

I'm cool with either way. Another thing I just realized, the convention in JS is upper camel case fns signify a class, thus must be instantiated with new - we're breaking this when a key can be constructed with dataset.Key() (I believe with Int and Double as well). Having a bunch of new Key()s passed as arguments could look a little verbose, so for this reason, I would rather see normal arrays passed as arguments, having the new Keys constructed from them internally. Then, when a key must be constructed manually, the new datastore.Key() will be less of an eyesore.

The other option, of course, is just making it dataset.key().

rakyll · 2014-08-08T00:28:39Z

I'm cool with either way. Another thing I just realized, the convention in JS is upper camel case fns signify a class

Yes, what I do is not kosher :( new Key is pretty verbose, I'd prefer dataset.key or datastore.key. Same with Int and Double.

I would rather see normal arrays passed as arguments

It breaks the reusability of the key instances.

stephenplusplus · 2014-08-08T00:32:26Z

It would be nice to force consistency. dataset.key is alright with me.

rakyll · 2014-08-08T00:55:41Z

Lowercased. Will send changes to Int and Double on a different PR.

datastore: Introduce Key type

* chore(main): release 2.1.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/5b03461e-47c0-40e8-a8ad-c465ee146cc5/targets - [ ] To automatically regenerate this PR, check this box.

🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/nodejs-bigquery-reservation/compare/v1.1.6...v1.2.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#100](https://www.github.com/googleapis/nodejs-bigquery-reservation/issues/100)) ([0047223](https://www.github.com/googleapis/nodejs-bigquery-reservation/commit/004722310ece662732fe60c8941be1b30214ed6d)) ### Bug Fixes * **build:** migrate to using main branch ([#97](https://www.github.com/googleapis/nodejs-bigquery-reservation/issues/97)) ([2e5a332](https://www.github.com/googleapis/nodejs-bigquery-reservation/commit/2e5a332b21067dd73ec6d2b218b87b61b8ebf59e)) * **deps:** google-gax v2.24.1 ([#99](https://www.github.com/googleapis/nodejs-bigquery-reservation/issues/99)) ([3a4cdec](https://www.github.com/googleapis/nodejs-bigquery-reservation/commit/3a4cdec8d028f0d6fd6d8ebc3977c00231b290bb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

@summer-ji-eng

- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 424244721 Source-Link: googleapis/googleapis@4b6b01f Source-Link: googleapis/googleapis-gen@8ac83fb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9

* docs: Updating copyright to 2022 PiperOrigin-RevId: 429555895 Source-Link: googleapis/googleapis@c222724 Source-Link: googleapis/googleapis-gen@2487eca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ4N2VjYWYyODU2ODA4OTkwYzM0ZDliZWRkMzM4NWU1YjJmYzhlYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jsdoc](https://togithub.com/jsdoc/jsdoc) | [`^3.6.6` -> `^4.0.0`](https://renovatebot.com/diffs/npm/jsdoc/3.6.11/4.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/compatibility-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/confidence-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>jsdoc/jsdoc</summary> ### [`v4.0.0`](https://togithub.com/jsdoc/jsdoc/blob/HEAD/CHANGES.md#400-November-2022) [Compare Source](https://togithub.com/jsdoc/jsdoc/compare/3.6.11...084218523a7d69fec14a852ce680f374f526af28) - JSDoc releases now use [semantic versioning](https://semver.org/). If JSDoc makes backwards-incompatible changes in the future, the major version will be incremented. - JSDoc no longer uses the [`taffydb`](https://taffydb.com/) package. If your JSDoc template or plugin uses the `taffydb` package, see the [instructions for replacing `taffydb` with `@jsdoc/salty`](https://togithub.com/jsdoc/jsdoc/tree/main/packages/jsdoc-salty#use-salty-in-a-jsdoc-template). - JSDoc now supports Node.js 12.0.0 and later. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-resource-settings).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/4de22315-84b1-493d-8da2-dfa7688128f5/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@94421c4

@summer-ji-eng

- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 424244721 Source-Link: googleapis/googleapis@4b6b01f Source-Link: googleapis/googleapis-gen@8ac83fb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468735472 Source-Link: googleapis/googleapis@cfa1b37 Source-Link: googleapis/googleapis-gen@09b7666 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDliNzY2NjY1NjUxMGY1YjAwYjg5M2YwMDNhMGJhNTc2NmY5ZTI1MCJ9

fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e

datastore: Introduce Key type.

874a147

stephenplusplus reviewed Aug 7, 2014
View reviewed changes

lib/datastore/entity.js

@@ -43,6 +43,12 @@ var signToOrderDict = {

'+': 'ASCENDING'

};

function Key(path) {

this.path_ = path;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

datastore: Fixing regression test to support the Key type.

9c8b153

stephenplusplus reviewed Aug 7, 2014
View reviewed changes

regression/datastore.js

var postKeyId = '123456789';

ds.save({ key: ['Post', postKeyId], data: post }, function(err, key) {

var postKey = datastore.Key('Post', 123456789)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

rakyll added 2 commits August 7, 2014 15:41

Fix lint error.

cb165f3

Fixing README samples with Key type.

71bfec7

stephenplusplus reviewed Aug 7, 2014
View reviewed changes

lib/datastore/index.js

return new entity.Key(path);

}

return new entity.Key([].slice.call(arguments));

},

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Remove unnecessary handling for array type

158aa9b

Lowercase Key initializer.

53d4f56

stephenplusplus added a commit that referenced this pull request Aug 8, 2014

Merge pull request #101 from rakyll/keytype

a9ad149

datastore: Introduce Key type

stephenplusplus merged commit a9ad149 into googleapis:master Aug 8, 2014

sofisl pushed a commit that referenced this pull request Sep 27, 2022

Enable no-var in eslint (#101)

f83fa71

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-recommender #3409

Merged

4 tasks

This was referenced Oct 13, 2022

migrate code from googleapis/nodejs-bigquery-reservation #3413

Merged

migrate code from googleapis/nodejs-policy-troubleshooter #3414

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(deps): use google-gax v3.5.2 (#101)

5b7c8c4

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-life-sciences #3583

Merged

migrate code from googleapis/nodejs-contact-center-insights #3584

Merged

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-resource-settings #3585

Merged

migrate code from googleapis/nodejs-bigquery-storage #3599

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-kms #3601

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

Add iam_policy proto (#101)

e0e74a9

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-access-approval #3605

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-dms #3611

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-private-catalog #3616

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 16, 2022

docs(node): support "stable"/"preview" release level (#1312) (#101)

a9e2179

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-network-connectivity #3643

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 17, 2022

fix(package): update @google-cloud/common to version 0.20.0 (#101)

dc78e6a

sofisl mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

4 tasks

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

remove that whitespace (#101)

5a4b17b

sofisl pushed a commit that referenced this pull request Jan 24, 2023

fix(deps): update dependency yargs to v12 (#101)

99fc3ef

sofisl pushed a commit that referenced this pull request Jan 25, 2023

fix(deps): update dependency yargs to v12 (#101)

1788b97

sofisl pushed a commit that referenced this pull request Sep 14, 2023

chore(deps): update dependency typescript to v3 (#101)

1783a04

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

This was referenced Nov 28, 2023

[Snyk] Fix for 21 vulnerabilities takeratta/google-cloud-node#28

Open

[Snyk] Fix for 1 vulnerabilities takeratta/google-cloud-node#46

Open

mikolajroszak mentioned this pull request May 7, 2024

[Snyk] Upgrade figures from 3.2.0 to 6.1.0 mikolajroszak/google-cloud-node#9

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

datastore: Introduce Key type #101

datastore: Introduce Key type #101

rakyll commented Aug 7, 2014

stephenplusplus commented Aug 7, 2014

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Aug 7, 2014

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Aug 7, 2014

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Aug 7, 2014

rakyll commented Aug 7, 2014

stephenplusplus commented Aug 8, 2014

rakyll commented Aug 8, 2014

stephenplusplus commented Aug 8, 2014

rakyll commented Aug 8, 2014

datastore: Introduce Key type #101

datastore: Introduce Key type #101

Conversation

rakyll commented Aug 7, 2014

stephenplusplus commented Aug 7, 2014

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Aug 7, 2014

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Aug 7, 2014

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Aug 7, 2014

rakyll commented Aug 7, 2014

stephenplusplus commented Aug 8, 2014

rakyll commented Aug 8, 2014

stephenplusplus commented Aug 8, 2014

rakyll commented Aug 8, 2014