Address code review feedback

GoogleCloudPlatform · Jun 8, 2023 · b4e1b27 · b4e1b27
1 parent 76cf596
commit b4e1b27
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/src/BadRequestError.php b/src/BadRequestError.php
@@ -21,7 +21,8 @@
 use Exception;
 
 /**
- * BadRequestError indicates a malformatted request.
+ * BadRequestError indicates a malformatted request. This is thrown internally
+ * when a typed function cannot deserialize the request body.
  * @internal
  */
 class BadRequestError extends Exception

diff --git a/src/CloudEventFunctionWrapper.php b/src/CloudEventFunctionWrapper.php
@@ -62,10 +62,9 @@ public function __construct(callable $function, bool $marshalToCloudEventInterfa
 
     private function throwInvalidFirstParameterException(): void
     {
-        $class = $this->getFunctionParameterClassName();
         throw new LogicException(sprintf(
             'Your function must have "%s" as the typehint for the first argument',
-            $class
+            $this->getFunctionParameterClassName()
         ));
     }
 

diff --git a/src/TypedFunctionWrapper.php b/src/TypedFunctionWrapper.php
@@ -72,6 +72,11 @@ private function throwInvalidFirstParameterException(): void
         );
     }
 
+    /**
+     * @param ServerRequestInterface $request
+     * @return ResponseInterface
+     * @throws BadRequestException
+     */
     public function execute(ServerRequestInterface $request): ResponseInterface
     {
         try {