Adds the option to disable the x-content-type-options header #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds X-Content-Type-Options as a kwarg so it can be disabled.
Added the x_xss_protection option
tunetheweb
reviewed
May 21, 2021
flask_talisman/talisman.py
Outdated
| @@ -284,8 +293,11 @@ def _set_frame_options_headers(self, headers, options): | |||
| options['frame_options_allow_from']) | |||
|
|
|||
| def _set_content_security_policy_headers(self, headers, options): | |||
| headers['X-XSS-Protection'] = '1; mode=block' | |||
| headers['X-Content-Type-Options'] = 'nosniff' | |||
| if self.x_xxs_protection: | |||
There was a problem hiding this comment.
Suggested change
| if self.x_xxs_protection: | |
| if self.x_xss_protection: |
Adds tests for the X-XSS-Protection option and the X-Content-Type-Options.
Fixed a typo
|
I think that failure is due to Python 3.4 becoming unsupported by libraries like Suggest you remove that version from travis.yml, noxfile.py and setup.py to get this to pass? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.