Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kustomization.yaml for cos #131

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

JohnPaton
Copy link
Contributor

This will allow users to include this daemonset in their downstream builds by using

resources:
- http://github.com/GoogleCloudPlatform/container-engine-accelerators.git//nvidia-driver-installer/cos/

in their own kustomization.yaml files

@JohnPaton
Copy link
Contributor Author

Pinging @chardch :)

@chardch
Copy link
Contributor

chardch commented Jan 8, 2020

Thanks for the change @JohnPaton! Have you tested this on all supported GKE versions that support kustomization and the ones that don't?

@JohnPaton
Copy link
Contributor Author

JohnPaton commented Jan 9, 2020

Hi @chardch, kustomize is independent of GKE, it's just a command line tool that allows for the combination and patching of kubernetes manifests (like templating, but better). Also known as kubectl -k if you have a recent kubectl. It runs locally (or as part of a CI/CD pipeline), not in kubernetes. This will just allow users of kustomize to include this resource in their own manifests, and to patch it as needed (if desired). Versions of GKE don't come into play at all (unless there's something I'm missing!)

@JohnPaton
Copy link
Contributor Author

@chardch is that clear enough?

@JohnPaton
Copy link
Contributor Author

This would still be useful! Pinging some recent contributors 😬 @ruiwen-zhao @pradvenkat @grac3gao

@pradvenkat pradvenkat self-requested a review November 7, 2021 23:53
Copy link
Contributor

@pradvenkat pradvenkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@pradvenkat pradvenkat merged commit 7a06071 into GoogleCloudPlatform:master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants